Backport of #22935 to 93X (Add a flag to prevent storage of LHEXMLStringProduct)

[fabiocos]

LHEXMLStringProduct is no more really used in production, and it is creating memory issues keeping on hold production in 93X. This PR adds a boolean flag as untracked parameter to activate/deactivate the storage of the xml output into the product, setting the default to "false" (i.e. do not store).

With the opportunity I fixed also the ExternalLHEAsciiDumper analyzer that was supposed to extract the xml file out of the edm root output, and that was no more working.

Both the "false" and "true" option have been tested in wf 512 (10 events), with a visible reduction of the final file size (84kB vs 112kB), and when the option was true the dumper was used to extract the xml file (216 kB after de-compression), proving that is again functional.

Tested in master (10_2_X), wf 512.0 not functional in 9_3_8.

Backport of #22935 (only changes in that PR, rest of the package left unchanged)

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

+code-checks

[fabiocos]

@kpedro88 @perrozzi @efeyazgan FYI, this needs to be tested on some working workflow

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27463/console Started: 2018/04/12 17:54

[cmsbuild]

+1
Tested at: a1cbbc7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22947/27463/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22947/27463/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2624448
• DQMHistoTests: Total failures: 222
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2624049
• DQMHistoTests: Total skipped: 177
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 105 log files, 8 edm output root files, 25 DQM output files

[perrozzi]

I confirm that I can run succesfully with this commit under 93x and I observe a reduction of the output file size. approving

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

merge