Add layer counting capability to PixelActivityFilter

[JanFSchulte]

Backport of #22951

Adds possibility to cut on number of pixel layers with clusters for the 90m beta* run.

[cmsbuild]

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_10_1_X.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Add layer counting capability to PixelActivityFilter #22951

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27476/console Started: 2018/04/13 13:13

[cmsbuild]

-1

Tested at: ba34a65

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22952/27476/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

1001.0 step1

DAS Error

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27500/console Started: 2018/04/16 07:32

[cmsbuild]

+1
Tested at: ba34a65
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22952/27500/summary.html

[cmsbuild]

Comparison job queued.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22952/27500/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2506331
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2506154
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.94000000009 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1

[venturia]

Have you considered the possibility to add a black list of modules (detid) not to be considered when the number of hits are computed?

[JanFSchulte]

@venturia No, I have never considered this. So far there has been so request from the users of this filter to be able to do this.

[venturia]

Since I have understood that the people interested have to tune the cuts, I am wondering if rejecting noisy modules could be part of the tuning process and, therefore, this feature could be useful