Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DQM module to make uGT data/emulator comparisons (backport) #22962

Conversation

apana
Copy link
Contributor

@apana apana commented Apr 13, 2018

Backport of #22907 and #22961

This PR add a new DQM module to make uGT data/emulator comparisons and also add option to use prescale column from unpacked GlobalAlgBlk in emulator (#22907). Also adds a check that the GlobalAlgBlk is not empty when trying to get the prescale column number from the unpacked data (#22961).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2018

A new Pull Request was created by @apana (Leonard Apanasvich) for CMSSW_10_1_X.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
L1Trigger/L1TGlobal

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Apr 17, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27519/console Started: 2018/04/17 08:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22962/27519/summary.html

Comparison Summary:

  • You potentially added 42886 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2506331
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506154
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 692.32 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@thomreis
Copy link
Contributor

+1

@thomreis
Copy link
Contributor

backport of #22907

with an additional fix: #22961

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 7, 2018

@apana @thomreis is this PR effectively changing the behaviour of the emulator? There is no just DQM changes here...

@fabiocos fabiocos mentioned this pull request May 11, 2018
6 tasks
@fabiocos
Copy link
Contributor

+1

for CMSSW_10_1_5

@cmsbuild cmsbuild merged commit 87a3073 into cms-sw:CMSSW_10_1_X May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants