New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
double EM enrichment filter support for HepMCfilter #22980
double EM enrichment filter support for HepMCfilter #22980
Conversation
…a (class name not yet changed)
…r type of method filter()
…nges needed to make this a BaseHepMCFilter instead of a EDFilter
…to GeneratorInterface/Core to avoid circular dependency / missing symbols at linking time
…an unknown enrichment filter to a later segmentation violation
… factored out from it into PythiaHepMCFilterGammaGamma
…netic enrichment generator level filter
…omagnetic enrichment filter
…nt filter for HepMCfilter framework
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22980/4363 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22980/4363/git-diff.patch You can run |
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22980/4384 |
Pull request #22980 was updated. @cmsbuild, @efeyazgan, @perrozzi can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@andreh7 ok, the only way t avpid the root dependdency would be to move the class to use the FourVector from SimpleVector in HepMC. I think it could be fine like this, GenFilters already depends on root. |
Comparison is ready Comparison Summary:
|
@perrozzi although you had already sign and the change was minor, could you please sign it again? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This pull request adds support for using the double EM enrichment filter code in the HepMCfilter framework as well as using the same filter code still from the 'classic'
PythiaFilterGammaGamma
.(this will allow generating double EM enriched samples with Madgraph/aMC@NLO more efficiently by retrying PYTHIA hadronization multiple times per hard event)
As suggested by @alberto-sanchez we also included a standalone test configuration (
GeneratorInterface/GenFilters/test/test_doubleEMEnrichingHepMCfilter.py
) running on a 35 event .lhe file .The code builds and runs on
CMSSW_10_2_X_2018-04-11-2300
.@gourangakole has done some testing of the filtered events.
Please let us know if you require changes/additions etc.