Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New geometry scenarios #2304

Merged
merged 7 commits into from Feb 18, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 5, 2014

  • Add new 2023 scenarios

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

New geometry scenarios

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Feb 5, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
50001 step1

runTheMatrix-results/50001_TTbar_14TeV+TTbarFSP2+HARVESTFSP2/step1_TTbar_14TeV+TTbarFSP2+HARVESTFSP2.log

60001 step1

runTheMatrix-results/60001_TTbar_14TeV+TTbarFSP2Forw+HARVESTFSP2Forw/step1_TTbar_14TeV+TTbarFSP2Forw+HARVESTFSP2Forw.log

15001 step4

runTheMatrix-results/15001_FourMuPt1_200+FourMuPt1_200_UPG2019_300+DIGIUP19300+RECOUP19300+HARVESTUP19300/step4_FourMuPt1_200+FourMuPt1_200_UPG2019_300+DIGIUP19300+RECOUP19300+HARVESTUP19300.log
----- Begin Fatal Exception 05-Feb-2014 12:22:41 CET-----------------------
An exception of category 'Conditions mismatch' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmHarvesting'
   [2] Calling beginRun for module HcalMonitorClient/'hcalClient'
Exception Message:
Requested conditions of type HcalPedestals for cell (0x42006101) (HB 2,1,1) got conditions for cell (0x4200608d) (HB 1,13,1)
----- End Fatal Exception -------------------------------------------------

3400 step4

runTheMatrix-results/3400_FourMuPt1_200+FourMuPt1_200_UPG2019+DIGIUP19+RECOUP19+HARVESTUP19/step4_FourMuPt1_200+FourMuPt1_200_UPG2019+DIGIUP19+RECOUP19+HARVESTUP19.log
----- Begin Fatal Exception 05-Feb-2014 12:22:41 CET-----------------------
An exception of category 'Conditions mismatch' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmHarvesting'
   [2] Calling beginRun for module HcalMonitorClient/'hcalClient'
Exception Message:
Requested conditions of type HcalPedestals for cell (0x42006101) (HB 2,1,1) got conditions for cell (0x4200608d) (HB 1,13,1)
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2304/19/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (but tests are reportedly failing). @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

@cmsbuild these are known errors in CMSSW_6_2_X before this pull request is applied. I've added a full description of what these are to the comments on #2301.

@ktf
Copy link
Contributor

ktf commented Feb 5, 2014

You have 3 options:

  • If you want to have a limited set of test running you should say so when proposing a pull request.
  • If you want those tests to be disabled for all of them you should say so. We can of course change this later.
  • Best is of course fixing the tests...

'Geometry/CSCGeometryBuilder/data/cscSpecsFilter.xml',
'Geometry/CSCGeometryBuilder/data/cscSpecs.xml',
'Geometry/RPCGeometryBuilder/data/RPCSpecs.xml',
'Geometry/GEMGeometryBuilder/data/v4/GEMSpecs.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geometry/GEMGeometryBuilder/data/v4/GEMSpecs.xml does not exist anylonger. Can you change v4 to v5?

@andersonjacob
Copy link
Contributor

@ianna Are we waiting for more on this request @dildick seemed to indicate there is one last thing? Should I start testing this one or wait for a small change?

@dildick
Copy link
Contributor

dildick commented Feb 12, 2014

Yes, those GEMSpecs versions need to be changed.

Implementing dildick's comments for pull request 2304
@mark-grimes
Copy link

merge

Tested on CMSSW_6_2_X_SLHC_2014-02-18-0200: extended pixel GEN-SIM test; GEM test; 3300, 3400, 4100, 4400, 40001, 50002, 60002, 4502, 4500, 5001 and 15001 (old numbering scheme) all fine. Tests for 2023 scenarios are in the works but at least nothing existing is broken.

@cmsbuild
Copy link
Contributor

Pull request #2304 was updated. @civanch, @ojeda, @danduggan, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rovere, @deguio, @Degano, @ktf, @nclopezo can you please check and sign again.

cmsbuild added a commit that referenced this pull request Feb 18, 2014
@cmsbuild cmsbuild merged commit f59ece4 into cms-sw:CMSSW_6_2_X_SLHC Feb 18, 2014
@ianna ianna deleted the new-geometry-scenarios branch October 26, 2015 16:25
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants