Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[94XminiAOD][updated GT] Change HcalRespCorrs and updated BS #23044

Merged
merged 1 commit into from Apr 25, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Apr 23, 2018

Updated GTs [94X]

  1. 94X_dataRun2_v6 -> 94X_dataRun2_v7
  1. 94X_dataRun2_relval_v11 -> 94X_dataRun2_relval_v12

@lpernie
Copy link
Contributor Author

lpernie commented Apr 23, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27621/console Started: 2018/04/23 20:20

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca Pernie) for CMSSW_9_4_MAOD_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23044/27621/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 508 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 157
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721174
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@lpernie
Copy link
Contributor Author

lpernie commented Apr 24, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@lpernie @arunhep do we have a corresponding PR for master?

@lpernie
Copy link
Contributor Author

lpernie commented Apr 24, 2018

Hello @fabiocos ,
The tags we are adding are already present in master [1].
They where never back-propagated to 94X.

[1]
You can check in https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoCond.py#L29
https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoCond.py#L31

@fabiocos
Copy link
Contributor

+1

content already present in master, this PR supports the tests of #22713

@cmsbuild cmsbuild merged commit 2278ab5 into cms-sw:CMSSW_9_4_MAOD_X Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants