Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert ALCAHARVDSIPIXELCALRUN1 so that an actually full DQM output file is produced #23063

Merged
merged 1 commit into from May 3, 2018

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 26, 2018

For some reason, if the SiPixelQuality AlCaHarvester is run for last in wf. 1001.0, the output DQM file is empty in PR tests.
This in turn makes the comparison with baseline useless, as when the relmon command is run, a division by zero occurs, crashing the processs.
I am not sure why this happens, so I am cc'ing here @tocheng and @cerminar, just to make sure there is not something fishy lurking there.
At any rate, as we'd like to keep the relmon meaningful, to check the content of the SiStripGains... Harvesters plots, I propose to invert the order, so that we actually get a full harvested DQM output to test.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27659/console Started: 2018/04/26 18:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23063/27659/summary.html

The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2495054
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2494877
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 27 files compared)
  • Checked 110 log files, 9 edm output root files, 29 DQM output files

@kpedro88
Copy link
Contributor

+1

@lpernie
Copy link
Contributor

lpernie commented Apr 26, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 2, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27743/console Started: 2018/05/02 11:36

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23063/27743/summary.html

The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23063/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2721257
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721073
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 115 log files, 14 edm output root files, 30 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented May 3, 2018

@GurpreetSinghChahal, @prebello, @fabozzi any objection against this change?

@fabozzi
Copy link
Contributor

fabozzi commented May 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

+1

@cmsbuild cmsbuild merged commit 89d7390 into cms-sw:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants