New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert ALCAHARVDSIPIXELCALRUN1 so that an actually full DQM output file is produced #23063
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23063/4469 |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Configuration/PyReleaseValidation @GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Comparison Summary:
|
+1 |
+1 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@GurpreetSinghChahal, @prebello, @fabozzi any objection against this change? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
For some reason, if the
SiPixelQuality
AlCaHarvester is run for last in wf. 1001.0, the output DQM file is empty in PR tests.This in turn makes the comparison with baseline useless, as when the relmon command is run, a division by zero occurs, crashing the processs.
I am not sure why this happens, so I am cc'ing here @tocheng and @cerminar, just to make sure there is not something fishy lurking there.
At any rate, as we'd like to keep the relmon meaningful, to check the content of the
SiStripGains...
Harvesters plots, I propose to invert the order, so that we actually get a full harvested DQM output to test.