Fix hgcal ageing

[rovere]

Mainly python changes in order to treat ageing within HGCAL correctly. All involved configuration parameters have been assigned to RefToPSet so that their handling all along the release is cleaner and not subject to the specific load sequences of the different cff/cfi/cfg involved in different steps (DIGI+RECO).
I decided to leave the customization as is (i.e. via a call to customize) rather than migrate everything to some specific sub-era since many other detectors would have been affected. It could be an improvement for the future if deemed useful.
Finally, I modified the customization function that now has only to change the RefToPset definitions in order to perform its task.

@malgeri

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23076/4482

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23076/4482/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23076/4482/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23076/4485

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HGCalSimProducers
SimGeneral/MixingModule

@perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @vandreev11, @edjtscott, @sethzenz, @makortel, @felicepantaleo, @sviret, @kpedro88, @lgray, @cseez, @pfs, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27688/console Started: 2018/04/27 12:44

[civanch]

+1

[perrotta]

+1

• HGCal ageing parameters defined via refToPSet: implementation corresponds to what declared in the description
• No changes expected with respect to the code in the baseline release, no changes observed in the jemkins comparisons of the upgrade workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27870/console Started: 2018/05/08 22:25

[cmsbuild]

+1
Tested at: a411741
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23076/27870/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23076/27870/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2713614
• DQMHistoTests: Total failures: 2222
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2711209
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[fabiocos]

+1