Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-176 Backport PR # 23134 to update AlCaReco o/p collection #23137

Merged
merged 1 commit into from May 18, 2018

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 3, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

A new Pull Request was created by @bsunanda for CMSSW_10_1_X.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented May 3, 2018

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27785/console Started: 2018/05/03 23:30

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23137/27785/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2507116
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506939
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.079 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 20434.0,... ): 0.006 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 20434.0,... ): 0.006 KiB DT/EventInfo
  • DQMHistoSizes: changed ( 20434.0,... ): 0.005 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 20434.0 ): 0.003 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 5.1,... ): 0.008 KiB RecoTauV/EventInfo
  • DQMHistoSizes: changed ( 9.0,... ): 0.007 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 9.0,... ): 0.006 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 9.0,... ): 0.005 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 9.0,... ): 0.005 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 9.0,... ): 0.005 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 9.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@abdoulline
Copy link

@arunhep, @lpernie
Could you, please, approve it?

@arunhep
Copy link
Contributor

arunhep commented May 8, 2018

@abdoulline same question as here : #23134 (comment)

@arunhep
Copy link
Contributor

arunhep commented May 8, 2018

+1
look for the discussion here : #23134 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5f02f5a into cms-sw:CMSSW_10_1_X May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants