HCALDQM: Monitor bad capid rotation, uHTR/L1T mismatches (10_2_X)

[DryRun]

Adds the following, mostly related to the issues seen so far in 2018:

• Monitor bad capid rotation. (BX - capid) % 4 should be a constant.
• Monitor uHTR-L1T mismatches. This is copied straight from the L1T DQM code, but it's extremely useful for HCAL.

Minor additions:

• Add LED pin diode plots to local DQM.
• UMNioTask now handles LED events correctly, instead of labeling them HF.
• Implement code rule check as suggested by Fabio. These were all "using namespace * in header" violations, which were fairly ubiquitous in the HcalCommon infrastructure.

[cmsbuild]

Pull request #23140 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23140/4659

[cmsbuild]

Pull request #23140 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27952/console Started: 2018/05/15 14:18

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 1d1bc22
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23140/27952/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23140/27952/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2715235
• DQMHistoTests: Total failures: 2401
• DQMHistoTests: Total nulls: 552
• DQMHistoTests: Total successes: 2712099
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5893.321 KiB( 29 files compared)
• DQMHistoSizes: changed ( 8.0,... ): 224.647 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 8.0,... ): 0.188 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 2.625 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 4.53 ): 20.688 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 136.731 ): 1.527 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 136.788,... ): 373.909 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 136.788 ): 8.035 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 10224.0,... ): 0.199 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 4.22 ): 17.438 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 1000.0 ): 4.000 KiB Hcal/DigiRunHarvesting
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[fabiocos]

+1