Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving HLT:PRef to 2017 pp Ref menu (94X) #23166

Merged
merged 1 commit into from May 14, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented May 8, 2018

Moving HLT:PRef to 2017 pp Ref menu (94X)
Based on CMSSW_9_4_7
Needed for MC production

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_9_4_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27854/console Started: 2018/05/08 13:16

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23166/27854/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721229
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2018

@Martin-Grunewald @franzoni @klute do I understand correctly that this change is effectively modifying the HLT in simulation compared to the existing production? Would not this mean breaking backward compatibility of physics content?

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
The new HLT:PRef menu is the menu used in 2017 for the 5 TeV pp reference run. It is separate from any other standard data taking (pp, HI, ...); as far as I know the old one has not been used in any MC production for a long time (it dates back to 2015), so there is no breakage. In fact the update in this PR is requested for a planned MC production with the 2017 5 TeV pp ref menu which this PR updates to.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 050b398 into cms-sw:CMSSW_9_4_X May 14, 2018
@gsfs
Copy link
Contributor

gsfs commented May 16, 2018

Confirming that no official MC was run with the previous version of the HLT:PRef menu in 94X and that we are eagerly awaiting a new CMSSW_9_4_X release with this PR included so that official MC can begin for the 2017G pp run at 5 TeV.

@Martin-Grunewald Martin-Grunewald deleted the HLT2017PRef94X branch November 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants