EMTF three fixes to unpacking and emulation bugs, 10_1_X back-port

[abrinke1]

Back-port of #23136

[cmsbuild]

A new Pull Request was created by @abrinke1 for CMSSW_10_1_X.

It involves the following packages:

DataFormats/L1TMuon
EventFilter/L1TRawToDigi
L1Trigger/L1TMuonEndCap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from EMTF three fixes to unpacking and emulation bugs #23136

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27868/console Started: 2018/05/08 18:21

[thomreis]

backport of #23136

[cmsbuild]

+1
Tested at: a13ad9b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23170/27868/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23170/27868/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2508502
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2508325
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

@abrinke1 @thomreis as far as I can see the modified DataFormat is a transient one, not part of any persistent data tier, do you confirm? Furthermore, besides MC tests in the IB, how has been this code verified?

[thomreis]

Yes, the data format is transient.
For the testing @abrinke1 has the details.

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1