Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers in RecoEgamma/EgammaTools #23180

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented May 9, 2018

Add missing headers for passing check-headers scram check

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

@mrodozov
Copy link
Contributor Author

mrodozov commented May 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27888/console Started: 2018/05/09 18:06

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23180/27888/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713999
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713815
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@perrotta
Copy link
Contributor

+1

  • The fix is technical, and it makes sense
  • No effect in jenkins tests, as it should

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@mrodozov : out of curiosity, what is the check-headers test that you run?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9c16521 into cms-sw:master May 10, 2018
@mrodozov
Copy link
Contributor Author

mrodozov commented May 18, 2018

#15248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants