[GCC 8.1] Fixed const correctness for operator()

[smuzaffar]

To avoid GCC 8 build errors like

../c++/8.1.1/bits/stl_tree.h: In instantiation of 'class std::_Rb_tree<HcalDcsMap::Item, HcalDcsMap::Item, std::_Identity<HcalDcsMap::Item>, HcalDcsMapAddons::LessByDcsId, std::allocator<HcalDcsMap::Item> >':
.../c++/8.1.1/bits/stl_set.h:133:17:   required from 'class std::set<HcalDcsMap::Item, HcalDcsMapAddons::LessByDcsId>'
.../CMSSW_10_2_X_2018-05-16-1100/src/CondFormats/HcalObjects/interface/HcalDcsMap.h:171:44:   required from here
  /build/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc810/external/gcc/8.1.0/include/c++/8.1.1/bits/stl_tree.h:457:21: error: static assertion failed: comparison object must be invocable as const
        static_assert(is_invocable_v<const _Compare&, const _Key&, const _Key&>,

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23224/4692

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27996/console Started: 2018/05/16 23:20

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/HcalObjects

@arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c16e1ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23224/27996/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23224/27996/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2740553
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2740369
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[lpernie]

+1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

@fabiocos please add this so that we can clear up the vast majority of compilation errors in the gcc 8 IB. Thanks.

[fabiocos]

+1