[GCC 8] [GEOM] Fixed const correctness for operator()

[smuzaffar]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23243/4720

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DetectorDescription/OfflineDBLoader

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28041/console Started: 2018/05/18 14:57

[cmsbuild]

+1
Tested at: 11c3cca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28041/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
58fdc16
6bdf89e
4ce5809
95ec6b8
8d539d4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28041/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28041/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28041/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23243/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2740553
• DQMHistoTests: Total failures: 7639
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2732731
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[fabiocos]

please test

differences look unrelated to this PR

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28079/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2901712
• DQMHistoTests: Total failures: 2247
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899275
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[smuzaffar]

@ianna , can you please sign this?

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28112/console Started: 2018/05/22 17:37

[cmsbuild]

+1
Tested at: 11c3cca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28112/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23243/28112/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2901712
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901521
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1