Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced ES alcareco size #23265

Merged
merged 1 commit into from May 22, 2018
Merged

Conversation

crovelli
Copy link
Contributor

This PR is to remove two unused collections from the output of the EcalESAlign Alcareco.
Once integrated in 10.2.x, we would like to back-port it to 10.1.x as well, as per A.Kumar's request

@cmsbuild cmsbuild changed the base branch from CMSSW_10_2_X to master May 21, 2018 13:16
@cmsbuild
Copy link
Contributor

@crovelli, CMSSW_10_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @crovelli for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@lpernie
Copy link
Contributor

lpernie commented May 21, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28093/console Started: 2018/05/21 23:04

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23265/28093/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901712
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901520
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@arunhep
Copy link
Contributor

arunhep commented May 22, 2018

@crovelli thanks for this PR. What is the impact on the size/event because of this ?

@arunhep
Copy link
Contributor

arunhep commented May 22, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@arunhep
Copy link
Contributor

arunhep commented May 22, 2018

@crovelli can we also please have the backport of this PR in 10.1.X?
we should aim to have it in next 10.1.X release which should be made in coming days for special beta=90m run.

@crovelli
Copy link
Contributor Author

crovelli commented May 22, 2018 via email

@crovelli
Copy link
Contributor Author

crovelli commented May 22, 2018 via email

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 15aa4e3 into cms-sw:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants