New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced ES alcareco size #23265
Reduced ES alcareco size #23265
Conversation
@crovelli, CMSSW_10_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23265/4756 |
A new Pull Request was created by @crovelli for master. It involves the following packages: Calibration/EcalAlCaRecoProducers @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@crovelli thanks for this PR. What is the impact on the size/event because of this ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@crovelli can we also please have the backport of this PR in 10.1.X? |
@arunhep, I did not check myself. According to our preshower experts this
will save 4%. There are other actions which may help in reducing the event
size but they require more studies and time.
…On Tue, May 22, 2018 at 2:26 PM, Arun Kumar ***@***.***> wrote:
@crovelli <https://github.com/crovelli> thanks for this PR. What is the
impact on the size/event because of this ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23265 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEhG3YkHIM2JbgBlSnyrapQcyJg-k8PDks5t1AP7gaJpZM4UG-MD>
.
|
done: #23278
…On Tue, May 22, 2018 at 2:28 PM, Arun Kumar ***@***.***> wrote:
@crovelli <https://github.com/crovelli> can we also please have the
backport of this PR in 10.1.X?
we should aim to have it in next 10.1.X release which should be made in
coming days for special beta=90m run.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23265 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEhG3eCSTDkqQ66bO1Z2C1pu4N1IOtMFks5t1ARdgaJpZM4UG-MD>
.
|
+1 |
This PR is to remove two unused collections from the output of the EcalESAlign Alcareco.
Once integrated in 10.2.x, we would like to back-port it to 10.1.x as well, as per A.Kumar's request