L1T offline DQM changes for muon resolution plots - 101x

[thomreis]

backport of #23279

Some upgrades to the L1T offline DQM muon resolution histograms.

• Proper delta phi calculation with wrap around at pi.
• Relative pT residuals.

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_10_1_X.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from L1T offline DQM changes for muon resolution plots #23279

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28111/console Started: 2018/05/22 17:29

[cmsbuild]

+1
Tested at: 2d19916
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23280/28111/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23280/28111/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2500840
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2500663
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[cmsbuild]

Pull request #23280 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again.

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28136/console Started: 2018/05/23 16:08

[cmsbuild]

+1
Tested at: 6402fab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23280/28136/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23280/28136/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2500578
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2500401
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.778 KiB( 28 files compared)
• DQMHistoSizes: changed ( 1330.0 ): 1.778 KiB L1T/L1TObjects
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[thomreis]

+1

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[thomreis]

Hi @fabiocos
can this be merged please. We would like to have the improvements available in the offline DQM soon.

[fabiocos]

@thomreis after passing test in the master pre-release of course

[thomreis]

Hi @fabiocos
did this pass the test in master already? I hope it can make it in 10_1_7.

[fabiocos]

+1

validated in CMSSW_10_2_0_pre5