Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cfg file for beampixel application for 2018 run #23282

Merged
merged 4 commits into from Jun 7, 2018
Merged

Updated cfg file for beampixel application for 2018 run #23282

merged 4 commits into from Jun 7, 2018

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented May 22, 2018

I changed from eras.Run2_2017 to eras.Run2_2018 and from PixelTracks_2017_cff to PixelTracks_cff

  • Mauro.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinardo (Mauro) for CMSSW_10_1_X.

It involves the following packages:

DQM/BeamMonitor
DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28118/console Started: 2018/05/22 23:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23282/28118/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2500840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2500663
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

Is this a backport? If so, please link it

@dinardo
Copy link
Contributor Author

dinardo commented May 29, 2018

Yeap,
from here: #22803

@dmitrijus
Copy link
Contributor

This is not a backport, number of changes is different.... :(

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Pull request #23282 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

@dinardo
Copy link
Contributor Author

dinardo commented Jun 5, 2018

Hi dmitrijus,
that's quite right.
This is a backporting of PR #22803 and PR #23261.
I've actually made also the PR #23264 which is included in this one (PR #23282).

Cheers,

  • Mauro.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28483/console Started: 2018/06/05 15:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23282/28483/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498020
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497843
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 6, 2018

Successfully tested and integrated in the Online DQM at P5. https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMP5TagCollector
Merged in master

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

@dinardo @jfernan2 one part of this PR is the backport of #23261 (why not mentioning it?). The update of the cfg is consistent with 10_2_X . It would be good to mark the backports explictly to avoid confusion.

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

+1

@cmsbuild cmsbuild merged commit c2333bc into cms-sw:CMSSW_10_1_X Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants