Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Geant4 tracking in magnetic field #23345

Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented May 25, 2018

This modification include two improvements:

  1. new Geant4 stepper G4DormandPrinc475 recommended by the Geant4 team
  2. "Smart tracking" option enabled with the threshold 2 MeV: if a charged particle has smaller energy loose parameters of tracking in field are used (mainly affect low-energy e-)

As a result, simulation histories will be different and full validation is required.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28218/console Started: 2018/05/26 19:11

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23345/28218/summary.html

Comparison Summary:

  • You potentially added 411 lines to the logs
  • Reco comparison results: 31554 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901706
  • DQMHistoTests: Total failures: 110646
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2790862
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.088 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 8.0 ): 3.194 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.560 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.644 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10224.0 ): -0.195 KiB SiStrip/MechanicalView
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@civanch
Copy link
Contributor Author

civanch commented May 27, 2018

+1
many différences are expected, because of different sim histories

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

This PR is at present meant for parallel tests on top of CMSSW_10_2_0_pre4

@fabiocos
Copy link
Contributor

hold

pending ongoing validation on top of CMSSW_10_2_0_pre4

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

unhold

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 19047c6 into cms-sw:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants