L1T DQM Plots for Kalman Filter for BMTF - CMSSW_10_2_X #23389

ghost · 2018-05-30T12:26:12Z

New DQM Plots for Kalman Filter. The whole task is based on DQM for Kalman BMTF

cmsbuild · 2018-05-30T12:26:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-05-30T12:28:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23389/4911

cmsbuild · 2018-05-30T12:28:42Z

A new Pull Request was created by @dtsitson for master.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

thomreis · 2018-05-30T12:30:55Z

please test

cmsbuild · 2018-05-30T12:31:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28292/console Started: 2018/05/30 14:31

thomreis · 2018-05-30T12:35:59Z

DQM/L1TMonitor/python/L1TdeStage2BMTF_cfi.py

@@ -16,5 +16,6 @@
    summaryTitle = cms.untracked.string("Summary of comparison between BMTF muons and BMTF emulator muons"),
    ignoreBin = cms.untracked.vint32(ignoreBinsDeStage2Bmtf),
    verbose = cms.untracked.bool(False),
+    kalman = cms.untracked.bool(False),


This is not needed since false is the default.

thomreis · 2018-05-30T12:46:48Z

DQM/L1TMonitor/src/L1TStage2BMTF.cc

+    bmtf_hwEta->setTitle("kbmtf_hwEta");
+    bmtf_hwLocalPhi->setTitle("kbmtf_hwLocalPhi");
+    bmtf_hwGlobalPhi->setTitle("kbmtf_hwGlobalPhi");
+    kmtf_hwPt  = ibooker.book1D("kmtf_hwPt", "HW p_{T}", 521, -0.5, 520.5);


To have a bmtf_hwPt and a kmtf_hwPt in the dame directory will cause confusion. I would rather reuse the bmtf_hwPt also for the kalman hw pt and eventually book that one with a different x axis range if you really want that.

thomreis · 2018-05-30T12:47:53Z

DQM/L1TMonitor/src/L1TStage2BMTF.cc

+    bmtf_hwEta_bx->setTitle("kbmtf_hwEta_bx;HW #eta; BX");
+    bmtf_hwLocalPhi_bx->setTitle("kbmtf_hwLocalPhi_bx;HW Local #phi; BX");
+    bmtf_hwPt_bx->setTitle("kbmtf_hwPt_bx;HW p_{T}; BX");
+    kmtf_hwQual_bx   = ibooker.book2D("kmtf_hwQual_bx"  , "HW Quality vs BX"      ,  13,   -0.5,  12.5,  5, -2.5, 2.5);


To have a bmtf_hwQual_bx and a kmtf_hwQual_bx in the dame directory will cause confusion. I would rather reuse the bmtf_hwQual_bx also for the kalman hw qual and eventually book that one with a different x axis range if you really want that.

thomreis · 2018-05-30T12:48:38Z

DQM/L1TMonitor/src/L1TStage2BMTF.cc

@@ -74,6 +75,28 @@ void L1TStage2BMTF::bookHistograms(DQMStore::IBooker &ibooker, const edm::Run& i
  bmtf_hwQual_bx   = ibooker.book2D("bmtf_hwQual_bx"  , "HW Quality vs BX"      ,  20,   -0.5,  19.5,  5, -2.5, 2.5);
  bmtf_hwQual_bx->setTitle("; HW Quality; BX");

+  if (kalman) {
+    ibooker.setCurrentFolder(monitorDir);


This is not needed.

thomreis · 2018-05-30T12:51:36Z

DQM/L1TMonitor/src/L1TStage2BMTF.cc


  edm::Handle<l1t::RegionalMuonCandBxCollection> bmtfMuon;
  eve.getByToken(bmtfToken, bmtfMuon);

+  if (kalman) {
+    for(int itBX=bmtfMuon->getFirstBX(); itBX<=bmtfMuon->getLastBX(); ++itBX) {
+      for(l1t::RegionalMuonCandBxCollection::const_iterator itMuon = bmtfMuon->begin(itBX); itMuon != bmtfMuon->end(itBX); ++itMuon) {


No need to do this in separate for loops. Just place it in the for loop where all the other variables are filled and there inside an if (kalman) statement.

thomreis · 2018-05-30T13:10:54Z

DQM/L1TMonitor/src/L1TStage2RegionalMuonCandComp.cc

@@ -178,6 +242,13 @@ void L1TStage2RegionalMuonCandComp::bookHistograms(DQMStore::IBooker& ibooker, c
  muColl2TrkAddr = ibooker.book2D("muTrkAddrColl2", (muonColl2Title+" mismatching muon track address"+trkAddrIgnoreText).c_str(), 10, -0.5, 9.5, 16, -0.5, 15.5);
  muColl2TrkAddr->setAxisTitle("key", 1);
  muColl2TrkAddr->setAxisTitle("value", 2);
+  if (kalman) {
+  ibooker.setCurrentFolder(monitorDir);


No need to set the monitoring directory again.

thomreis · 2018-05-30T13:11:51Z

DQM/L1TMonitor/interface/L1TStage2RegionalMuonCandComp.h

@@ -45,6 +44,9 @@ class L1TStage2RegionalMuonCandComp : public DQMEDAnalyzer {
  bool ignoreBadTrkAddr;
  std::vector<int> ignoreBin;
  bool verbose;
+  bool kalman;
+
+  int nbins=17;


Remove this variable. It does not need to be a class member.

thomreis · 2018-05-30T13:17:24Z

DQM/L1TMonitor/src/L1TStage2RegionalMuonCandComp.cc

@@ -52,45 +55,91 @@ void L1TStage2RegionalMuonCandComp::bookHistograms(DQMStore::IBooker& ibooker, c
  }

  // Subsystem Monitoring and Muon Output
+  if(!kalman){


Version with less code duplication:

int nbins = 17; if (kalman) { nbins += 2; } summary = ibooker.book1D("summary", (summaryTitle+trkAddrIgnoreText).c_str(), nbins, 1, nbins+1); summary->setBinLabel(BXRANGEGOOD, "BX range match", 1); ... summary->setBinLabel(TRACKADDRBAD, "track address mismatch", 1); if (kalman) { summary->setBinLabel(DXYBAD, "DXY mismatch", 1); summary->setBinLabel(PT2BAD, "P_{T}2 mismatch", 1); }

The same can be done for the booking of errorSummaryNum and errorSummaryDen.

thomreis · 2018-05-30T13:18:15Z

DQM/L1TMonitor/src/L1TStage2RegionalMuonCandComp.cc

+  }
+
+  if(!kalman) {
+    ibooker.setCurrentFolder(monitorDir);


No need to set the monitoring directory again.

thomreis · 2018-05-30T13:18:23Z

DQM/L1TMonitor/src/L1TStage2RegionalMuonCandComp.cc

-  errorSummaryDen->setBinLabel(RNMUON, "# muon collections", 1);
-  for (int i = RMUON; i <= RTRACKADDR; ++i) {
+  if(!kalman){
+    ibooker.setCurrentFolder(monitorDir);


No need to set the monitoring directory again.

thomreis · 2018-05-30T13:22:00Z

This PR requires the Kalman BMTF unpacker and the Kalman emulator. @panoskatsoulis please provide two PRs for those as well.

cmsbuild · 2018-05-30T14:39:47Z

-1

Tested at: 8f78536

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23389/28292/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17/step3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

150.0 step3

runTheMatrix-results/150.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018/step3_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

cmsbuild · 2018-05-30T14:39:49Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2018-06-08T19:12:24Z

+1
Tested at: 40ab829
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23389/28580/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
40ab829
ac4fdbc
a5acde6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23389/28580/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23389/28580/git-merge-result

cmsbuild · 2018-06-08T19:12:27Z

Comparison job queued.

cmsbuild · 2018-06-08T20:16:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23389/28580/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902639
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2902447
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 25376.68 KiB( 30 files compared)
DQMHistoSizes: changed ( 25202.0,... ): 1793.399 KiB L1T/L1TStage2BMTF
DQMHistoSizes: changed ( 25202.0,... ): 19.221 KiB L1TEMU/L1TdeStage2BMTF
Checked 128 log files, 14 edm output root files, 31 DQM output files

fabiocos · 2018-06-14T08:37:37Z

@dtsitson @thomreis @rekovic any news about this PR?

fabiocos · 2018-06-19T11:51:43Z

@dtsitson @thomreis @rekovic any news about this PR? Is it needed in 10_2_X?

ghost · 2018-06-19T11:56:50Z

Hi @fabiocos
This is the master branch for Kalman filter. I need to complete some extra changes . I hope that I will finish them until the end of week and after that I need to create a new one for P5 .

rekovic · 2018-06-19T15:34:37Z

@dtsitson
This PR is good as is, since it contains the needed KBMTF version of the unpacker. Any additional change needed for DQM can be added to P5 as PRs in TagCollector.

rekovic · 2018-06-19T15:34:43Z

+1

fabiocos · 2018-06-20T07:28:37Z

@rekovic @dtsitson sorry, regardless of the temporary import outside the official CMSSW that are done in online DQM at P5, the release should be the place where to have the master store of the updates. In any case, DQM updates can be managed even later, while we shouiild have the unpacker possibly frozen by now.

@jfernan2 @dmitrijus could you please check and sign it in case for DQM?

fabiocos · 2018-06-20T11:22:00Z

@dtsitson as far as I can see the L1TStage2BMTF directory is now duplicated into a corresponding Kalman version, and this adds some 1.7 MB of memory occupancy. Is this duplication to be considered as temporary, for the commissioning of this code, or permanent?

jfernan2 · 2018-06-21T08:08:43Z

+1
Upon pending answer to @fabiocos question about folder duplication

cmsbuild · 2018-06-21T08:09:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-06-21T11:06:22Z

@jfernan2 thanks, I had a discussion with @rekovic yesterday about this and I understand that for the time being this is needed for studies, I do not see a special stress for memory usage in this moment but wanted to better understand

fabiocos · 2018-06-21T11:06:51Z

+1

thomreis · 2018-07-16T09:13:06Z

@dtsitson do you want to run this at P5? Is there a 10_1_X backport PR?

Dimitrios Tsitsonis added 3 commits May 29, 2018 16:58

Check the emulator for kalman

f856d5d

Check for kalamn emulator

693beef

Kalman plots for data and emulator

8f78536

cmsbuild added this to the CMSSW_10_2_X milestone May 30, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 30, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 30, 2018

cmsbuild added tests-started and removed tests-pending labels May 30, 2018

thomreis suggested changes May 30, 2018

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 30, 2018

Some new changes for binning

8c76feb

cmsbuild removed code-checks-approved comparison-notrun labels May 30, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 8, 2018

cmsbuild added l1-approved and removed l1-pending labels Jun 19, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 21, 2018

cmsbuild added orp-approved and removed orp-pending labels Jun 21, 2018

cmsbuild merged commit fcabd47 into cms-sw:master Jun 21, 2018

ghost mentioned this pull request Jul 23, 2018

L1T DQM Plots for Kalman Filter for BMTF - backport - CMSSW_10_1_X #23953

Closed

rekovic mentioned this pull request Jul 27, 2018

Last Changes for BMTF Unpacker cms-l1t-offline/cmssw#690

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L1T DQM Plots for Kalman Filter for BMTF - CMSSW_10_2_X #23389

L1T DQM Plots for Kalman Filter for BMTF - CMSSW_10_2_X #23389

ghost commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

thomreis commented May 30, 2018

cmsbuild commented May 30, 2018 •

edited

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis May 30, 2018

thomreis commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented Jun 8, 2018

cmsbuild commented Jun 8, 2018

cmsbuild commented Jun 8, 2018

fabiocos commented Jun 14, 2018

fabiocos commented Jun 19, 2018

ghost commented Jun 19, 2018

rekovic commented Jun 19, 2018

rekovic commented Jun 19, 2018

fabiocos commented Jun 20, 2018

fabiocos commented Jun 20, 2018

jfernan2 commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

fabiocos commented Jun 21, 2018

fabiocos commented Jun 21, 2018

thomreis commented Jul 16, 2018

L1T DQM Plots for Kalman Filter for BMTF - CMSSW_10_2_X #23389

L1T DQM Plots for Kalman Filter for BMTF - CMSSW_10_2_X #23389

Conversation

ghost commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

thomreis commented May 30, 2018

cmsbuild commented May 30, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomreis commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented Jun 8, 2018

cmsbuild commented Jun 8, 2018

cmsbuild commented Jun 8, 2018

fabiocos commented Jun 14, 2018

fabiocos commented Jun 19, 2018

ghost commented Jun 19, 2018

rekovic commented Jun 19, 2018

rekovic commented Jun 19, 2018

fabiocos commented Jun 20, 2018

fabiocos commented Jun 20, 2018

jfernan2 commented Jun 21, 2018

cmsbuild commented Jun 21, 2018

fabiocos commented Jun 21, 2018

fabiocos commented Jun 21, 2018

thomreis commented Jul 16, 2018

cmsbuild commented May 30, 2018 •

edited