electron reco modifications for 2018 heavy ion era #23404

bi-ran · 2018-05-31T14:58:17Z

this PR includes the following modifications to electron reconstruction for the 2018 heavy ion era:

raise supercluster energy thresholds
removal of tracker-driven electrons

these changes affect mainly very low-pt electrons, and are in line with the (old) custom heavy ion reconstruction sequence.

@mandrenguyen

cmsbuild · 2018-05-31T14:58:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-05-31T15:00:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23404/4936

cmsbuild · 2018-05-31T15:01:12Z

A new Pull Request was created by @bi-ran for master.

It involves the following packages:

RecoEgamma/EgammaElectronProducers
RecoParticleFlow/PFTracking
TrackingTools/GsfTracking

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@varuns23, @mmarionncern, @Sam-Harper, @makortel, @felicepantaleo, @jainshilpi, @GiacomoSguazzoni, @rovere, @lgray, @bellan, @bachtis, @cbernet, @gpetruc, @ebrondol, @VinInn, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-05-31T15:30:04Z

On 5/31/18 7:58 AM, bi-ran wrote: this PR includes the following modifications to electron reconstruction for the 2018 heavy ion era: * raise supercluster energy thresholds * removal of tracker-driven electrons these changes affect mainly very low-pt electrons, and are in line with the (old) custom heavy ion reconstruction sequence. @mandrenguyen <https://github.com/mandrenguyen>

please provide a link to some slides (in an HI meeting?) that describe the observed or expected performance changes, including also the estimates of the CPU time changes Thank you.

slava77 · 2018-05-31T15:31:28Z

RecoEgamma/EgammaElectronProducers/python/ecalDrivenElectronSeedsParameters_cff.py

@@ -81,3 +81,5 @@

 )

+from Configuration.Eras.Modifier_pp_on_AA_2018_cff import pp_on_AA_2018
+pp_on_AA_2018.toModify(ecalDrivenElectronSeedsParameters, SCEtCut = cms.double(15.0))


please drop the types in all modifications.
This is a safer use of syntax against typos and also helps with possible future parameter name changes and migrations

slava77 · 2018-05-31T15:32:11Z

@cmsbuild please test

cmsbuild · 2018-05-31T15:32:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28335/console Started: 2018/05/31 17:33

cmsbuild · 2018-05-31T17:59:59Z

+1
Tested at: 585437f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23404/28335/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f2ce72a
4f00f42
4ae1881
1b095d1
fad5d51
aba54f7
c92686b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23404/28335/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23404/28335/git-merge-result

cmsbuild · 2018-05-31T18:00:03Z

Comparison job queued.

cmsbuild · 2018-05-31T19:51:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23404/28335/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902471
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2902279
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

cmsbuild · 2018-06-01T03:07:56Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-01T03:10:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23404/4945

cmsbuild · 2018-06-01T03:12:02Z

Pull request #23404 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2018-06-01T17:25:02Z

@cmsbuild please test

cmsbuild · 2018-06-01T17:25:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28380/console Started: 2018/06/01 19:25

cmsbuild · 2018-06-01T19:27:23Z

+1
Tested at: f48840f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23404/28380/summary.html

cmsbuild · 2018-06-01T19:27:25Z

Comparison job queued.

cmsbuild · 2018-06-01T23:49:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23404/28380/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902471
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2902279
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

slava77 · 2018-06-05T18:14:21Z

+1

for #23404 f48840f

code changes are in line with the PR description and more clearly so with the description of this PR in the RECO meeting on June 1 ("Move SC thresholds to 15 GeV, and remove tracker-driven electrons"). The changes affect only Run2_2018_pp_on_AA
jenkins tests pass
local tests with 200 events of wf 158.0 (uses Run2_2018_pp_on_AA) show expected behavior.
- RECO time went down from 9.0 s/ev to 8.9 s/ev primarily related to the modified electron reco modules (the related reco modules were not particularly costly to start with).
- AOD size reduces ~negligibly.

cmsbuild · 2018-06-05T18:14:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-06-06T07:46:38Z

+1

bi-ran added 2 commits May 31, 2018 14:06

remove tracker-driven electron sequence

cf8c395

raise supercluster energy thresholds

585437f

cmsbuild added this to the CMSSW_10_2_X milestone May 31, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 31, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2018

slava77 reviewed May 31, 2018

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels May 31, 2018

cmsbuild added tests-approved and removed tests-started labels May 31, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 31, 2018

drop types in all modifications

f48840f

cmsbuild removed code-checks-approved comparison-available labels Jun 1, 2018

cmsbuild added comparison-pending tests-pending labels Jun 1, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 1, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 1, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 1, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 5, 2018

cmsbuild added orp-approved and removed orp-pending labels Jun 6, 2018

cmsbuild merged commit 3cc8867 into cms-sw:master Jun 6, 2018

mandrenguyen mentioned this pull request Jun 7, 2018

Remove OOT photons from 2018 heavy-ion (AA) era #23371

Merged

bi-ran deleted the electron_reco_pp_on_AA branch April 4, 2019 22:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

electron reco modifications for 2018 heavy ion era #23404

electron reco modifications for 2018 heavy ion era #23404

bi-ran commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

slava77 commented May 31, 2018 via email

slava77 May 31, 2018

slava77 commented May 31, 2018

cmsbuild commented May 31, 2018 •

edited

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

slava77 commented Jun 1, 2018

cmsbuild commented Jun 1, 2018 •

edited

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

slava77 commented Jun 5, 2018

cmsbuild commented Jun 5, 2018

fabiocos commented Jun 6, 2018

electron reco modifications for 2018 heavy ion era #23404

electron reco modifications for 2018 heavy ion era #23404

Conversation

bi-ran commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

slava77 commented May 31, 2018 via email

slava77 May 31, 2018

Choose a reason for hiding this comment

slava77 commented May 31, 2018

cmsbuild commented May 31, 2018 • edited

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented May 31, 2018

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

slava77 commented Jun 1, 2018

cmsbuild commented Jun 1, 2018 • edited

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

cmsbuild commented Jun 1, 2018

slava77 commented Jun 5, 2018

cmsbuild commented Jun 5, 2018

fabiocos commented Jun 6, 2018

cmsbuild commented May 31, 2018 •

edited

cmsbuild commented Jun 1, 2018 •

edited