fix hdrs in Alignment #23444

mrodozov · 2018-06-04T13:05:11Z

Fix headers related to #15248

mrodozov · 2018-06-04T13:05:20Z

please test

cmsbuild · 2018-06-04T13:05:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-04T13:07:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23444/4983

cmsbuild · 2018-06-04T13:07:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28418/console Started: 2018/06/04 15:08

cmsbuild · 2018-06-04T13:07:55Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Alignment/LaserAlignment
Alignment/SurveyAnalysis
Alignment/TrackerAlignment

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-06-04T13:14:43Z

-1

Tested at: 66b0f42

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23444/28418/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputCSCfromPins.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyDBUploader.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputTrackerFromDB.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/src/SurveyAlignmentSensor.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/src/SurveyParameters.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputCSCfromPins.cc:42:6: error: prototype for 'void SurveyInputCSCfromPins::orient(LocalVector, LocalVector, double, double, double&, double&, double&, double&, double&, double&)' does not match any in class 'SurveyInputCSCfromPins'
 void SurveyInputCSCfromPins::orient(LocalVector LC1, LocalVector LC2, double a, double b, double &T, double &dx, double &dy, double &dz, double &PhX, double &PhZ) {
      ^~~~~~~~~~~~~~~~~~~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputCSCfromPins.cc:21:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputCSCfromPins.h:28:8: error: candidate is: void SurveyInputCSCfromPins::orient(align::LocalVector, align::LocalVector, double, double, double&, double&, double&, double&, double&, double&)
   void orient(align::LocalVector LC1, align::LocalVector LC2, double a, double b, double &T, double &dx, double &dy, double &dz, double &PhX, double &PhZ);

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/test/SurveyInputDummy.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/test/SurveyTest.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/test/SurveyInputTest.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/test/SurveyDBReader.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/test/Modules.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputCSCfromPins.cc:42:30: error: out-of-line definition of 'orient' does not match any declaration in 'SurveyInputCSCfromPins'
void SurveyInputCSCfromPins::orient(LocalVector LC1, LocalVector LC2, double a, double b, double &T, double &dx, double &dy, double &dz, double &PhX, double &PhZ) {
                             ^~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-03-2300/src/Alignment/SurveyAnalysis/plugins/SurveyInputCSCfromPins.h:28:15: note: type of 1st parameter of member declaration does not match definition ('Vector3DBase' vs 'Vector3DBase')
  void orient(align::LocalVector LC1, align::LocalVector LC2, double a, double b, double &T, double &dx, double &dy, double &dz, double &PhX, double &PhZ);
              ^

cmsbuild · 2018-06-04T13:14:44Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2018-06-04T14:20:47Z

The code-checks are being triggered in jenkins.

mrodozov · 2018-06-04T14:20:58Z

please test

cmsbuild · 2018-06-04T14:23:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23444/4999

cmsbuild · 2018-06-04T14:23:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28427/console Started: 2018/06/04 16:26

cmsbuild · 2018-06-04T14:23:32Z

Pull request #23444 was updated. @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please check and sign again.

cmsbuild · 2018-06-04T16:35:46Z

+1
Tested at: f5d601c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23444/28427/summary.html

cmsbuild · 2018-06-04T16:35:49Z

Comparison job queued.

cmsbuild · 2018-06-04T21:25:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23444/28427/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902471
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2902280
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

lpernie · 2018-06-05T02:21:58Z

+1

cmsbuild · 2018-06-05T02:22:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-06-05T07:31:37Z

+1

cmsbuild added this to the CMSSW_10_2_X milestone Jun 4, 2018

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Jun 4, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 4, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 4, 2018

fix hdrs in Alignment

f5d601c

mrodozov force-pushed the fix-hdrs-Alignment branch from 66b0f42 to f5d601c Compare June 4, 2018 14:20

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jun 4, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 4, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 4, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 4, 2018

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 5, 2018

cmsbuild added orp-approved and removed orp-pending labels Jun 5, 2018

cmsbuild merged commit b57099d into cms-sw:master Jun 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix hdrs in Alignment #23444

fix hdrs in Alignment #23444

mrodozov commented Jun 4, 2018

mrodozov commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018 •

edited

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

mrodozov commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018 •

edited

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

lpernie commented Jun 5, 2018

cmsbuild commented Jun 5, 2018

fabiocos commented Jun 5, 2018

fix hdrs in Alignment #23444

fix hdrs in Alignment #23444

Conversation

mrodozov commented Jun 4, 2018

mrodozov commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018 • edited

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

mrodozov commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018 • edited

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

cmsbuild commented Jun 4, 2018

lpernie commented Jun 5, 2018

cmsbuild commented Jun 5, 2018

fabiocos commented Jun 5, 2018

cmsbuild commented Jun 4, 2018 •

edited

cmsbuild commented Jun 4, 2018 •

edited