New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 2to3 migration tool fix_basestring #23452
python 2to3 migration tool fix_basestring #23452
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23452/4991 |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Alignment/MuonAlignment @cmsdoxy, @kpedro88, @fabozzi, @nsmith-, @rekovic, @thomreis, @vanbesien, @arizzi, @perrotta, @civanch, @monttj, @cmsbuild, @GurpreetSinghChahal, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @cerminar, @slava77, @ggovi, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Wouldn't this break our python 7 code if we happen to have any unicode? See |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
+1 |
+1
|
+1 |
@Dr15Jones @ggovi @fabozzi @prebello @cmsdoxy could you please check and sign it in case? |
+1 |
+1 |
+1 |
@Dr15Jones @davidlange6 I understand that this PR is ok to move forward |
+1 |
merge |
apply fixes.fix_basestring tool from python futurize tool