Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 2to3 migration tool fix_basestring #23452

Merged

Conversation

davidlange6
Copy link
Contributor

apply fixes.fix_basestring tool from python futurize tool

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/MuonAlignment
CalibMuon/DTCalibration
Configuration/AlCa
Configuration/PyReleaseValidation
Documentation/ReferenceManualScripts
FWCore/ParameterSet
FWCore/PythonUtilities
FWCore/Skeletons
L1Trigger/L1TMuonEndCap
PhysicsTools/HeppyCore
PhysicsTools/PythonAnalysis
RecoHI/HiEgammaAlgos
RecoLuminosity/LumiDB
SimTracker/TrackerMaterialAnalysis
Utilities/ReleaseScripts
Validation/RecoTrack

@cmsdoxy, @kpedro88, @fabozzi, @nsmith-, @rekovic, @thomreis, @vanbesien, @arizzi, @perrotta, @civanch, @monttj, @cmsbuild, @GurpreetSinghChahal, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @cerminar, @slava77, @ggovi, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @Martin-Grunewald, @wddgit, @thomreis, @threus, @mmusich, @pakhotin, @makortel, @jhgoh, @trocino, @yetkinyilmaz, @cbernet, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @wmtford, @mschrode, @ebrondol, @mtosi, @dgulhan, @mandrenguyen, @jazzitup, @yenjie, @kurtejung this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

Wouldn't this break our python 7 code if we happen to have any unicode? See
https://docs.python.org/2/library/functions.html#basestring

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28432/console Started: 2018/06/04 16:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison job queued.

@arunhep
Copy link
Contributor

arunhep commented Jun 5, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 5, 2018

+1

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2018

+1

  • Technical
  • Jenkins tests pass

@thomreis
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@Dr15Jones @ggovi @fabozzi @prebello @cmsdoxy could you please check and sign it in case?

@fabozzi
Copy link
Contributor

fabozzi commented Jun 11, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented Jun 12, 2018

+1

@Dr15Jones
Copy link
Contributor

+1
I guess we will just try to avoid using unicode.

@fabiocos
Copy link
Contributor

@Dr15Jones @davidlange6 I understand that this PR is ok to move forward

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f88fa7e into cms-sw:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment