Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers Fireworks #23487

Merged
merged 1 commit into from Jun 6, 2018
Merged

fix headers Fireworks #23487

merged 1 commit into from Jun 6, 2018

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 5, 2018

Fix headers related to #15248

@mrodozov
Copy link
Contributor Author

mrodozov commented Jun 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28488/console Started: 2018/06/05 16:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Fireworks/Electrons
Fireworks/Muons
Fireworks/ParticleFlow
Fireworks/Tracks

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28490/console Started: 2018/06/05 16:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented Jun 5, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2018

+1

@cmsbuild cmsbuild merged commit 4e89471 into cms-sw:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants