Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hdrs FWCore #23512

Merged
merged 1 commit into from Jun 7, 2018
Merged

fix hdrs FWCore #23512

merged 1 commit into from Jun 7, 2018

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 6, 2018

Fix headers related to #15248

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jun 6, 2018
@mrodozov
Copy link
Contributor Author

mrodozov commented Jun 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28526/console Started: 2018/06/06 18:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

FWCore/SOA
FWCore/TestProcessor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23512/28526/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902630
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902435
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.018 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1330.0 ): -0.018 KiB L1T/L1TObjects
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

+1

@cmsbuild cmsbuild merged commit 950fd72 into cms-sw:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants