Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HLT menu to V2.2 (102X) #23527

Merged
merged 4 commits into from Jun 10, 2018
Merged

Conversation

Martin-Grunewald
Copy link
Contributor

Update of HLT menu to V2.2 (102X)
Based on CMSSW_10_2_0_pre5.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

The code-checks are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28556/console Started: 2018/06/08 10:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23527/28556/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892208
  • DQMHistoTests: Total failures: 1349
  • DQMHistoTests: Total nulls: 30
  • DQMHistoTests: Total successes: 2890639
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -897.074 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 136.85,... ): -70.206 KiB HLT/Objects
  • DQMHistoSizes: changed ( 136.85 ): -40.317 KiB HLT/TAU
  • DQMHistoSizes: changed ( 136.85 ): 22.412 KiB HLT/EGM
  • DQMHistoSizes: changed ( 136.85,... ): 3.072 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 136.85,... ): 0.779 KiB HLT/BTV
  • DQMHistoSizes: changed ( 10824.0,... ): -360.332 KiB HLT/BPH
  • DQMHistoSizes: changed ( 10824.0,... ): -100.991 KiB HLT/TAU
  • DQMHistoSizes: changed ( 10824.0,... ): 98.843 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 10824.0,... ): 22.428 KiB HLT/EGM
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
Chris, please sign for core (addOnTests.py)

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 8, 2018

@Martin-Grunewald how is this PR reducing the DQM histogram size? Switching off some older paths for which histograms are therefore no more produced?

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
Indeed I agree. Please note this menu is already online.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 92750a9 into cms-sw:master Jun 10, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLTv22for102X branch November 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants