Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a LowPU version of the HP Beam Spot workflow for PCL #23558

Merged
merged 4 commits into from Jun 13, 2018

Conversation

cerminar
Copy link
Contributor

A new PCL workflow is defined targeting the Beam-Spot computation in LowPU environment.
This is defining PromptCalibProdBeamSpotHPLowPU and the corresponding AlCaHarvesting steps.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerminar for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers
Configuration/AlCa
Configuration/EventContent
Configuration/StandardSequences

@arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 11, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28621/console Started: 2018/06/11 15:47

@arunhep
Copy link
Contributor

arunhep commented Jun 11, 2018

@cerminar do you also plan to have a backport in 10.1.X ?

@arunhep
Copy link
Contributor

arunhep commented Jun 11, 2018

answering myself : #23559

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28674/console Started: 2018/06/13 15:34

@cmsbuild
Copy link
Contributor

Pull request #23558 was updated. @prebello, @arunhep, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @cerminar, @GurpreetSinghChahal, @pohsun, @davidlange6, @fabiocos, @lpernie can you please check and sign again.

@fabiocos
Copy link
Contributor

@sarafiorendi @cerminar running 1030 on 1000 events: there are 4 lumi section transitions, in the first one

%MSG-w PVFitter: AlcaBeamSpotProducer:alcaBeamSpotProducerHP@endLumi 13-Jun-2018 16:32:58 CEST Run: 297557 Lumi: 148
3D beam spot fit failed in 1st iteration
%MSG

for the following two I still get "Inversion failed", while the last one looks ok "read without any error message)

@fabiocos
Copy link
Contributor

@cerminar @sarafiorendi @arunhep I understand that this is not anyway a show-stopped to get the new PCL code integrated, possibly a further tuning (in case it is really needed) can happen in a patch

@fabiocos
Copy link
Contributor

+operations

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@sarafiorendi
Copy link
Contributor

sarafiorendi commented Jun 13, 2018

Hi @fabiocos,

I think the error message(s) is coming from the alcaBeamSpotProducerHP workflow, not the newly introduced one (alcaBeamSpotProducerHPLowPU).
Step3 of this runTheMatrix runs both the HP fit (with more severe cuts on the input vertices and errorScale=1.1) and HPLowPU fit (w/o cuts and errorScale=0.9), and in fact if I run the two workflows offline on 1000 events I see converging fits for all the LSs for the second one (not for the first, which converges only in LS 152).

@fabiocos
Copy link
Contributor

@sarafiorendi you are correct, they both run together, thanks for cross checking.

@arunhep
Copy link
Contributor

arunhep commented Jun 13, 2018

+1

@fabiocos
Copy link
Contributor

+1

PdmV changes are working (wf 1030 used for this validation), the comparion was ok, and wf 1030 is not used in comparisons

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 762bb8a into cms-sw:master Jun 13, 2018
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23558/28674/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902004
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901812
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants