New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a LowPU version of the HP Beam Spot workflow for PCL #23558
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23558/5148 |
A new Pull Request was created by @cerminar for master. It involves the following packages: Calibration/TkAlCaRecoProducers @arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@cerminar do you also plan to have a backport in 10.1.X ? |
answering myself : #23559 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23558/5149 |
The tests are being triggered in jenkins. |
@sarafiorendi @cerminar running 1030 on 1000 events: there are 4 lumi section transitions, in the first one %MSG-w PVFitter: AlcaBeamSpotProducer:alcaBeamSpotProducerHP@endLumi 13-Jun-2018 16:32:58 CEST Run: 297557 Lumi: 148 for the following two I still get "Inversion failed", while the last one looks ok "read without any error message) |
@cerminar @sarafiorendi @arunhep I understand that this is not anyway a show-stopped to get the new PCL code integrated, possibly a further tuning (in case it is really needed) can happen in a patch |
+operations |
+1 |
Comparison job queued. |
Hi @fabiocos, I think the error message(s) is coming from the alcaBeamSpotProducerHP workflow, not the newly introduced one (alcaBeamSpotProducerHPLowPU). |
@sarafiorendi you are correct, they both run together, thanks for cross checking. |
+1 |
+1 PdmV changes are working (wf 1030 used for this validation), the comparion was ok, and wf 1030 is not used in comparisons |
merge |
Comparison is ready Comparison Summary:
|
A new PCL workflow is defined targeting the Beam-Spot computation in LowPU environment.
This is defining
PromptCalibProdBeamSpotHPLowPU
and the corresponding AlCaHarvesting steps.