Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation of the readout and digitization for the MIP timing detector barrel #23584

Merged
merged 14 commits into from Jun 27, 2018

Conversation

casarsa
Copy link
Contributor

@casarsa casarsa commented Jun 14, 2018

The proposed changes concern the MIP timing detector simulation and, in part, the MIP timing detector reconstruction. An overview of the new code with some implementation details was presented at the MTD Simulation and Performance Meeting on June 8 (slides).

Several new features have been introduced in the digitization code of the barrel MIP detector:

  • fluctuations in energy and time due to the photostatistics;
  • time-of-arrival reading at different thresholds on the signal pulse shape;
  • smearing of the time of arrival to account for the SiPM timing resolution, the SiPM DCR, the electronic noise and the clock distribution.

Some changes were also required in the MIP timing detector reconstruction package both to preserve the backward compatibility and not to affect the simulation of the endcap MIP detetector.

The new code was tested with runTheMatrix.py: it passed all the steps of a TTbar and a TTbar+PU workflow.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @casarsa (Massimo Casarsa) for master.

It involves the following packages:

RecoLocalFastTime/Configuration
RecoLocalFastTime/FTLCommonAlgos
RecoLocalFastTime/FTLRecProducers
SimFastTiming/FastTimingCommon

@perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jun 14, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28687/console Started: 2018/06/14 11:48

@cmsbuild
Copy link
Contributor

@kpedro88
Copy link
Contributor

@fabiocos to add a workflow to the IB tests, you just need to edit: https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2023.py. But,
a) the workflow should run to completion
b) edits in that file will conflict with #23545, and I would prefer not to have to go through an (n+1)th round of signatures on that one.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23584/28761/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902013
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901821
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@kpedro88 yes, adding it is not an issue, I was asking Massimo to prepare for it. #23545 will get the precedence in this respect, don't worry

@kpedro88
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Jun 22, 2018

+1

@perrotta
Copy link
Contributor

If I am not wrong, in this implementation the following code was copied identically:

  • RecoLocalFastTime/FTLCommonAlgos/interface/MTDRecHitAlgoBase.h and RecoLocalFastTime/FTLCommonAlgos/interface/FTLRecHitAlgoBase.h
  • RecoLocalFastTime/FTLCommonAlgos/plugins/MTDRecHitAlgo.cc and RecoLocalFastTime/FTLCommonAlgos/plugins/FTLRecHitAlgo.cc
  • RecoLocalFastTime/FTLRecProducers/plugins/MTDRecHitProducer.cc and RecoLocalFastTime/FTLRecProducers/plugins/FTLRecHitProducer.cc

Is there any differentiation foreseen in the near future, or maybe some simplification can be allowed since now?

@casarsa
Copy link
Contributor Author

casarsa commented Jun 26, 2018 via email

@perrotta
Copy link
Contributor

+1

  • Reco updates in this PR pave the way to split MTD and FTL code in the simu/reco of the Timing detector
  • Up to now, the code is just duplicated, thus preserving backward compatibility with previous simulations
  • In a workflow which includes the D24 Phase2 geometry (22434.0, TTbar_14TeV_TuneCUETP8M1_2023D2) the new products are visible:
m::StrictWeakOrdering<FTLRecHit> >    "mtdRecHits"                "FTLBarrel"       "RECO"    
edm::SortedCollection<FTLRecHit,edm::StrictWeakOrdering<FTLRecHit> >    "mtdRecHits"                "FTLEndcap"       "RECO"    
edm::SortedCollection<FTLUncalibratedRecHit,edm::StrictWeakOrdering<FTLUncalibratedRecHit> >    "mtdUncalibratedRecHits"    "FTLBarrel"       "RECO"    
edm::SortedCollection<FTLUncalibratedRecHit,edm::StrictWeakOrdering<FTLUncalibratedRecHit> >    "mtdUncalibratedRecHits"    "FTLEndcap"       "RECO"    
  • No changes expected in the standard workflows used for jenkins tests, that do not use the new Timing geometry (era phase2_timing_layer_new)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f448739 into cms-sw:master Jun 27, 2018
@casarsa casarsa deleted the mc-btlSIM-devel branch June 27, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants