New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation of the readout and digitization for the MIP timing detector barrel #23584
Conversation
…nic noise and clock distribution
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23584/5183 |
A new Pull Request was created by @casarsa (Massimo Casarsa) for master. It involves the following packages: RecoLocalFastTime/Configuration @perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@fabiocos to add a workflow to the IB tests, you just need to edit: https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2023.py. But, |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
If I am not wrong, in this implementation the following code was copied identically:
Is there any differentiation foreseen in the near future, or maybe some simplification can be allowed since now? |
The duplication was decided to preserve the backward compatibility of
the reconstruction code and prepare for future developments. The MTD*
code will be differentiated from the FTL* in a forthcoming PR: the MTD
reconstruction code will be split into BTL and ETL with different
implementations.
…On 06/25/2018 10:03 AM, perrotta wrote:
If I am not wrong, in this implementation the following code was
copied identically:
* RecoLocalFastTime/FTLCommonAlgos/interface/MTDRecHitAlgoBase.h and
RecoLocalFastTime/FTLCommonAlgos/interface/FTLRecHitAlgoBase.h
* RecoLocalFastTime/FTLCommonAlgos/plugins/MTDRecHitAlgo.cc and
RecoLocalFastTime/FTLCommonAlgos/plugins/FTLRecHitAlgo.cc
* RecoLocalFastTime/FTLRecProducers/plugins/MTDRecHitProducer.cc and
RecoLocalFastTime/FTLRecProducers/plugins/FTLRecHitProducer.cc
Is there any differentiation foreseen in the near future, or maybe
some simplification can be allowed since now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23584 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFLySc2XZEsB_CirtvtshE7WHmBtQt04ks5uAJlLgaJpZM4UnoHQ>.
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The proposed changes concern the MIP timing detector simulation and, in part, the MIP timing detector reconstruction. An overview of the new code with some implementation details was presented at the MTD Simulation and Performance Meeting on June 8 (slides).
Several new features have been introduced in the digitization code of the barrel MIP detector:
Some changes were also required in the MIP timing detector reconstruction package both to preserve the backward compatibility and not to affect the simulation of the endcap MIP detetector.
The new code was tested with runTheMatrix.py: it passed all the steps of a TTbar and a TTbar+PU workflow.