Run2-hcx178 Usage of the correct Hcal geometry in FastSim

[bsunanda]

Output of SIM step should have uncollapsed depth for HCAL and collapsing is done only at RECO level

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23631/5277

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

FastSimulation/CaloGeometryTools
Geometry/HcalTowerAlgo

@ssekmen, @Dr15Jones, @lveldere, @civanch, @mdhildreth, @ianna, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28795/console Started: 2018/06/20 23:52

[cmsbuild]

+1
Tested at: 7577705
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23631/28795/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6bc486f
ec93696
95784ac
9846e30
912fac2
ff78b6a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23631/28795/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23631/28795/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23631/28795/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 252 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902133
• DQMHistoTests: Total failures: 4446
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2897497
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5641.442 KiB( 30 files compared)
• DQMHistoSizes: changed ( 10824.0,... ): 468.933 KiB CTPPS/common
• DQMHistoSizes: changed ( 1330.0 ): 14.246 KiB L1T/L1TObjects
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[kpedro88]

please test workflow 2017.1
(to make sure the issue noted in #23363 (comment) is gone)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28802/console Started: 2018/06/21 15:56

[bsunanda]

I did test it for the workflow 2017.1 and the issue is gone. In fact many of the HEP17 detId's were wrong earlier which are corrected now.

[ssekmen]

Thanks a lot for fixing this @bsunanda .

[cmsbuild]

+1
Tested at: 7577705
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23631/28802/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23631/28802/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23631/2017.1_TTbar_13_UP17+TTbarFS_13_UP17+HARVESTUP17FS+MINIAODMCUP17FS

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902147
• DQMHistoTests: Total failures: 4441
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2897516
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1