remove unused DigiSimLinkProducer and related configuration #23644
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23644/5296 |
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: SimTracker/SiStripDigitizer @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test number of DQM failures (HI, 2018..) cannot be explained by this PR, for any case, re-trigger tests |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
+1 |
|
Hi @VinInn, in step3: |
|
ok,
I always found them in RelVals.
will investigate more, still do not understand the asymmetry between Muon and Tracker
v.
… On 1 Aug, 2018, at 6:02 PM, Marco Musich ***@***.***> wrote:
Hi @VinInn,
about your specific question I am not sure, but regarding your query at https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3479.html it doens't depend on this PR.
I've run wf 110808.0 in the last 10.1.X IB (which doens't contain this PR) and there are no
edm::DetSetVector<StripDigiSimLink> "simSiStripDigis" "" "HLT"
in step3:
[10808.0_SingleMuPt100+SingleMuPt100_pythia8_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018]$ edmDumpEventContent step3.root | grep DigiSim
MuonDigiCollection<DTLayerId,DTDigiSimLink> "simMuonDTDigis" "" "HLT"
edm::DetSetVector<RPCDigiSimLink> "simMuonRPCDigis" "RPCDigiSimLink" "HLT"
edm::DetSetVector<StripDigiSimLink> "simMuonGEMDigis" "GEM" "HLT"
edm::DetSetVector<StripDigiSimLink> "simMuonCSCDigis" "MuonCSCStripDigiSimLinks" "HLT"
edm::DetSetVector<StripDigiSimLink> "simMuonCSCDigis" "MuonCSCWireDigiSimLinks" "HLT"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Since they are there in step2 I suppose they are just removed from the list of |
|
apparently.... |
|
no simDigis in step3 |
|
On 8/1/18 9:50 AM, Vincenzo Innocente wrote:
no simDigis anymore in step3
edmDumpEventContent step3.root | grep simSiPixelDigis
I have it in my relval file though
edmDumpEventContent part1.root | grep simSiPixelDigis
edm::DetSetVector "simSiPixelDigis" "" "HLT"
edm::DetSetVector "simSiPixelDigis" "" "HLT"
somebody decided that the file was too large...
even for singleMuon
I feel like these decisions were made before the LHC Big Bang
|
Greetings,
this is a follow-up of issue #23634.
As suggested by @makortel, apparently
DigiSimLinkProduceris not used anymore anywhere in the Strip digitization package. To avoid supporting unused code and duplicated configuration, we just propose to remove it.Passes local testing via
runTheMatrix.py -s.cc: @boudoul @echabert @mjansova