Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using early 2018 BS for 2018 MC relvals #23659

Merged
merged 1 commit into from Jun 24, 2018

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Jun 22, 2018

This PR is related to the deployment of the new RECO BS in the release for 2018 MC, that has happened with the merged PR #23619

Therefore we need to update the generated BS in 2018 MC relvals, to use the one from which the RECO BS was derived: Realistic25ns13TeVEarly2018Collision.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabozzi for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 22, 2018

FYI: @arunhep

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 22, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28839/console Started: 2018/06/22 20:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23659/28839/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2322 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 14887
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2884402
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabozzi
Copy link
Contributor Author

fabozzi commented Jun 24, 2018

+1

@fabiocos
Copy link
Contributor

@kpedro88 could you please check and sign it, unless you have comments?

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e9399b5 into cms-sw:master Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants