Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx117 Update HGCRecHit class #23662

Merged
merged 1 commit into from Jun 26, 2018
Merged

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jun 22, 2018

The print statement was corrected in view of multiple DetId definitions

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/HGCRecHit

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @felicepantaleo, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28841/console Started: 2018/06/22 21:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23662/28841/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@kpedro88
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

@bsunanda , this PR only updates the operator<<, not the HGCRecHit content as declared in the title: is there anything missing here? If not, maybe a more appropriate title could be chosen

@bsunanda bsunanda changed the title Phase2-hgx117 Update HGCRecHit content Phase2-hgx117 Update HGCRecHit class Jun 26, 2018
@bsunanda
Copy link
Contributor Author

@perrotta Done

@perrotta
Copy link
Contributor

Thank you @bsunanda

@perrotta
Copy link
Contributor

+1

  • This PR just updates the ostream operator of HGCRecHit in view of multiple DetId definitions
  • Jenkins tests pass with no modifications (none expected)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@bsunanda sorry, is there any further update of this DataFormat planned on the short term?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 995cb3f into cms-sw:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants