Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix header L1Trigger/L1TMuonOverlap #23672

Merged
merged 1 commit into from Jul 2, 2018
Merged

Conversation

mrodozov
Copy link
Contributor

Fix headers related to #15248
We start enforcing the rule today to fail the PR if it doesn't comply with the header check.
The remaining headers to be fixed are currently - 1, for which we are adding an exception until the issue opened about that header is addressed

Fix headers related to cms-sw#15248
We start enforcing the rule today to fail the PR if it doesn't comply with the header check.
The remaining headers to be fixed are currently - 1, for which we are adding an exception until the issue opened about that header is addressed
@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28867/console Started: 2018/06/25 14:36
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28868/console Started: 2018/06/25 14:57

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

L1Trigger/L1TMuonOverlap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 67de9c7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23672/28868/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28884/console Started: 2018/06/26 09:34
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28893/console Started: 2018/06/26 10:15

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23672/28893/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor

@nsmith-, @rekovic, @thomreis , can you please sign this?

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2018

+1

trivial technical fix

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2018

merge

@cmsbuild cmsbuild merged commit 317f065 into cms-sw:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants