New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix header L1Trigger/L1TMuonOverlap #23672
Conversation
Fix headers related to cms-sw#15248 We start enforcing the rule today to fail the PR if it doesn't comply with the header check. The remaining headers to be fixed are currently - 1, for which we are adding an exception until the issue opened about that header is addressed
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23672/5331 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: L1Trigger/L1TMuonOverlap @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 67de9c7 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 trivial technical fix |
merge |
Fix headers related to #15248
We start enforcing the rule today to fail the PR if it doesn't comply with the header check.
The remaining headers to be fixed are currently - 1, for which we are adding an exception until the issue opened about that header is addressed