Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch polymorphic exception by reference #23678

Merged
merged 2 commits into from Jun 26, 2018
Merged

catch polymorphic exception by reference #23678

merged 2 commits into from Jun 26, 2018

Conversation

Dr15Jones
Copy link
Contributor

This silences a gcc 8 warning.

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jun 25, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23678/5336

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23678/5336/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23678/5336/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@Dr15Jones
Modernize code
cd74c95 
Needed to pass code-checks
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23678/5337

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/Common
FWCore/PythonParameterSet
IOPool/Input
IOPool/TFileAdaptor
Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @rovere, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28878/console Started: 2018/06/25 21:45

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28880/console Started: 2018/06/25 23:21

@cmsbuild
Copy link
Contributor

-1

Tested at: cd74c95

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a3e3ad4
017a7d5
5c50974
1ba0ec2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28880/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28880/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28880/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestPoolInput had ERRORS
---> test testPythonParameterSet had ERRORS
---> test traits_t had ERRORS
---> test DetSetVector_t had ERRORS
---> test RefVector_t had ERRORS
---> test DataFrame_t had ERRORS
---> test exDSTV had ERRORS
---> test testMultiAssociation had ERRORS
---> test DictionaryTools_t had ERRORS
---> test exTrie had ERRORS
---> test OwnVector_t had ERRORS
---> test testBoostRange had ERRORS
---> test Trie_t had ERRORS
---> test testDataFormatsCommon had ERRORS
---> test MapOfVectors_t had ERRORS
---> test DetSetNewTS_t had ERRORS
---> test RefCore_t had ERRORS
---> test Ref_t had ERRORS
---> test Wrapper_t had ERRORS
---> test DetSetNew_t had ERRORS
---> test runtestPhysicsToolsNanoAOD had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test DQMTestStandaloneBuildOfDQMStore had ERRORS
---> test DQMFastMatchTest had ERRORS
---> test DQMQualityTestsExample had ERRORS
---> test runFastHadd had ERRORS
---> test testSchemaEvolution had ERRORS
---> test runTheWhiteRabbit had ERRORS
---> test TestDQMServicesFwkIOScripts had ERRORS
---> test testTauEmbeddingProducers had ERRORS
---> test test_TFileAdaptor_TFile had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a3e3ad4
017a7d5
5c50974
1ba0ec2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28880/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28880/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28880/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor

please test
cms-bot had an issue with unittests, this should be fixed now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28885/console Started: 2018/06/26 09:36

@cmsbuild
Copy link
Contributor

+1
Tested at: cd74c95
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28885/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23678/28885/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ae13862 into cms-sw:master Jun 26, 2018
@Dr15Jones Dr15Jones deleted the polymorphicException branch June 26, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @smuzaffar @fabiocos