pu jets in jet-core tracking for pp_on_AA_2018

[stepobr]

This PR makes one change to the tracking in the pp_on_AA_2018 era to be used for PbPb data this year. The default jet-core collection (ak4CaloJetsForTrk) is replaced by a similar one that applies PU subtraction. This allows proper tracking behaviour in PbPb, and is especially crucial for central events.

@abaty @cfmcginn @FHead @mandrenguyen

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23684/5344

[cmsbuild]

A new Pull Request was created by @stepobr for master.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @rappoccio, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28909/console Started: 2018/06/26 17:02

[cmsbuild]

+1
Tested at: b7d60d9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23684/28909/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23684/28909/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899289
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #23684 b7d60d9

• code changes are in line with the PR description
• jenkins tests pass (run time check of 158.0 is included)
• local tests show roughly expected behavior:
  • wf 158.0 200 events has no changes (there were 0 events with jet core tracks)
  • wf based on 230 filtered HI minbias events with ncoll > 3000 (out of 2K generated): jetCore with some tracks in 33 events in the baseline 10_2_0_pre5 has 0 events with this PR and jetCore-related module time goes down to small values.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@fabiocos
please clarify the status/plans of merging of this PR.
This only affects pp_on_AA workflows

[fabiocos]

+1

this PR modifies the physics output, but affecting only the processing of HI data, that is not the target of 10_2_X. So I consider as safe to add it even after the end of developments