Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopMonitoring: Updated fully hadronic paths and ele, fully hadronic t… #23691

Merged
merged 1 commit into from Jul 11, 2018

Conversation

skonstantinou
Copy link
Contributor

Fully hadronic paths have been updated according to [1]. The b-tagging algorithm changed from CSV to DeepCSV. Tighter cuts in the fully hadronic selection have been applied.
In the electron selection, the loose isolation cut has been removed (a cut on the relIso is included in electron ID)

[1] https://its.cern.ch/jira/browse/CMSHLT-1857

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @skonstantinou for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28920/console Started: 2018/06/27 11:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23691/28920/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892280
  • DQMHistoTests: Total failures: 714
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2891376
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7044.708 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 136.788,... ): -587.059 KiB HLT/TOP
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@skonstantinou @jfernan2 the description of the PR says that DeppCSV is added, but from the code I would naively say it is removed, could you please clarify?

@skonstantinou
Copy link
Contributor Author

skonstantinou commented Jul 11, 2018

@fabiocos @jfernan2 The b-tagging algorithm used for the fully hadronic paths has changed to DeepCSV [1].
This means that there is no difference between the selections in [2] and [3] and the latter can be removed

[1] https://github.com/cms-sw/cmssw/pull/23691/files#diff-148c698ded5b0a43d10260cde15eb620R360
[2] https://github.com/cms-sw/cmssw/pull/23691/files#diff-148c698ded5b0a43d10260cde15eb620L352
[3] https://github.com/cms-sw/cmssw/pull/23691/files#diff-148c698ded5b0a43d10260cde15eb620L560

@fabiocos
Copy link
Contributor

@skonstantinou ok thanks

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 561b8f1 into cms-sw:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants