Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Phase2 Tracker (T11) and corresponding workflow (D29) for testing and relvals purpose #23720

Merged
merged 4 commits into from Jul 10, 2018

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jun 29, 2018

Greetings
This PR aims to add a new version of the phase2 tracker for testing purpose as mentioned at the last simulation meeting with @kpedro88

This new Tracker (T11) is the same as T6 but 50x50 modules.
This Tracker would benefit to get relvals for physics performance in order to guide R&Ds choice and complete the picture (together with T6,T7,T8)

The corresponding Workflows for T11 is D29 (244xx)

I didn't add it in IB test, I don't think it's needed , but it can be added if prefered.
The PR test should therefore be launched with a 244xx WF

@emiglior FYI

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData

@prebello, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @civanch, @GurpreetSinghChahal, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @ghugo83, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@boudoul boudoul changed the title Adding a Phase2 Tracker (T11) and corresponding workflow (D29) or testing and relvals purpose Adding a Phase2 Tracker (T11) and corresponding workflow (D29) for testing and relvals purpose Jun 29, 2018
@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 29, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28951/console Started: 2018/06/29 11:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

@boudoul we can't launch the tests with the new workflow unless it's added to relval_2023 (it's fine with me to skip testing it explicitly here, we didn't test all the other tracker variations)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23720/28951/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 2
4.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • You potentially added 635 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2787698
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787524
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 123 log files, 14 edm output root files, 29 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 1, 2018

+1

@ianna
Copy link
Contributor

ianna commented Jul 4, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 5, 2018

@prebello @fabozzi please sign

@prebello
Copy link
Contributor

prebello commented Jul 5, 2018

sorry approved by mistake.. I am checking it

@prebello
Copy link
Contributor

prebello commented Jul 5, 2018

@kpedro88 not clear to me: are you going to skip phaseII workflows (D29 and D30) test as pointed above?

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 5, 2018

yes, we'll skip it for now

@prebello
Copy link
Contributor

prebello commented Jul 5, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 9, 2018

@fabiocos can this go in?

@fabiocos
Copy link
Contributor

+operations

addition of a new upgrade geometry scenario

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

workflow 24407.0 runs smoothly

@cmsbuild cmsbuild merged commit df9f4bb into cms-sw:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants