python2->3 remove keys() from len(dict.keys()) #23737

davidlange6 · 2018-07-03T13:02:44Z

len(dict.keys()) will not work in python3 as keys() will be an iterator. Fortunately len(dict) is the same functionality.

cmsbuild · 2018-07-03T13:04:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-07-03T13:07:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23737/5406

cmsbuild · 2018-07-03T13:07:49Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CalibMuon/DTCalibration
CondCore/Utilities
Configuration/Applications
Configuration/PyReleaseValidation
DQM/Integration
DQMServices/Components
FWCore/GuiBrowsers
FWCore/ParameterSet
FWCore/Utilities
RecoLuminosity/LumiDB
RecoMET/METFilters
Utilities/RelMon
Utilities/ReleaseScripts
Validation/Tools

@kpedro88, @fabozzi, @pohsun, @monttj, @arizzi, @perrotta, @vanbesien, @cmsbuild, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @jfernan2, @cerminar, @slava77, @ggovi, @fabiocos, @prebello, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @gpetruc, @lpernie can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @Martin-Grunewald, @thomreis, @threus, @seemasharmafnal, @mmarionncern, @makortel, @jdolen, @barvic, @tocheng, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mmusich, @clelange, @batinkov, @wddgit, @ahinzmann, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2018-07-03T14:42:51Z

please test

cmsbuild · 2018-07-03T14:43:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28992/console Started: 2018/07/03 16:44

cmsbuild · 2018-07-03T21:52:23Z

-1

Tested at: 0140f52

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
15c494f
dd762d7
93d716a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/28992/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/28992/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/28992/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testPythonParameterSet had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
15c494f
dd762d7
93d716a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/28992/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/28992/git-merge-result

cmsbuild · 2018-07-03T21:52:25Z

Comparison job queued.

cmsbuild · 2018-07-03T23:46:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/28992/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2899480
DQMHistoTests: Total failures: 24
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2899266
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

prebello · 2018-07-05T16:00:33Z

+1

based on tests-approved

cmsbuild · 2018-07-05T17:30:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23737/29014/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2899480
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2899282
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

pohsun · 2018-07-06T02:38:09Z

+1

fabiocos · 2018-07-06T08:35:16Z

+operations

fabiocos · 2018-07-06T08:36:15Z

@kpedro88 @slava77 @perrotta @ggovi @jfernan2 could you please check and sign or comment? Unless you have objections, I would like to move forward quickly with this PR

dmitrijus · 2018-07-06T08:53:21Z

+1

kpedro88 · 2018-07-06T14:33:15Z

+1

slava77 · 2018-07-08T11:10:24Z

+1

for #23737 0140f52

technical
jenkins tests pass

fabiocos · 2018-07-09T09:12:22Z

@ggovi please check, I would like to move forward with this PR by today

fabiocos · 2018-07-09T20:21:10Z

+1

technical update

fabiocos · 2018-07-09T20:21:18Z

merge

remove keys() from len(dict.keys())

0140f52

cmsbuild added this to the CMSSW_10_2_X milestone Jul 3, 2018

cmsbuild added alca-pending analysis-pending code-checks-pending comparison-pending core-pending db-pending dqm-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Jul 3, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 3, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2018

cmsbuild added tests-rejected and removed tests-started labels Jul 3, 2018

cmsbuild added tests-approved and removed tests-started labels Jul 5, 2018

cmsbuild added pdmv-approved and removed pdmv-pending labels Jul 5, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 5, 2018

cmsbuild added alca-approved and removed alca-pending labels Jul 6, 2018

cmsbuild added operations-approved and removed operations-pending labels Jul 6, 2018

cmsbuild added dqm-approved and removed dqm-pending labels Jul 6, 2018

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 6, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 8, 2018

cmsbuild added orp-approved and removed orp-pending labels Jul 9, 2018

cmsbuild merged commit 97ed105 into cms-sw:master Jul 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python2->3 remove keys() from len(dict.keys()) #23737

python2->3 remove keys() from len(dict.keys()) #23737

davidlange6 commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

davidlange6 commented Jul 3, 2018

cmsbuild commented Jul 3, 2018 •

edited

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

prebello commented Jul 5, 2018

cmsbuild commented Jul 5, 2018

pohsun commented Jul 6, 2018

fabiocos commented Jul 6, 2018

fabiocos commented Jul 6, 2018

dmitrijus commented Jul 6, 2018

kpedro88 commented Jul 6, 2018

slava77 commented Jul 8, 2018

fabiocos commented Jul 9, 2018

fabiocos commented Jul 9, 2018

fabiocos commented Jul 9, 2018

python2->3 remove keys() from len(dict.keys()) #23737

python2->3 remove keys() from len(dict.keys()) #23737

Conversation

davidlange6 commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

davidlange6 commented Jul 3, 2018

cmsbuild commented Jul 3, 2018 • edited

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

cmsbuild commented Jul 3, 2018

prebello commented Jul 5, 2018

cmsbuild commented Jul 5, 2018

pohsun commented Jul 6, 2018

fabiocos commented Jul 6, 2018

fabiocos commented Jul 6, 2018

dmitrijus commented Jul 6, 2018

kpedro88 commented Jul 6, 2018

slava77 commented Jul 8, 2018

fabiocos commented Jul 9, 2018

fabiocos commented Jul 9, 2018

fabiocos commented Jul 9, 2018

cmsbuild commented Jul 3, 2018 •

edited