Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EleEAData2012 #2376

Merged
merged 3 commits into from Feb 27, 2014
Merged

EleEAData2012 #2376

merged 3 commits into from Feb 27, 2014

Conversation

d4space
Copy link
Contributor

@d4space d4space commented Feb 9, 2014

kEleEAData2012 at EGammaCutBasedEleId.cc

@d4space d4space closed this Feb 9, 2014
@d4space d4space reopened this Feb 9, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2014

A new Pull Request was created by @d4space for CMSSW_5_3_X.

EleEAData2012

It involves the following packages:

EgammaAnalysis/ElectronTools

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Feb 10, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

vadler
vadler reviewed Feb 11, 2014
View reviewed changes
EgammaAnalysis/ElectronTools/src/EGammaCutBasedEleId.cc
@@ -302,7 +302,7 @@ unsigned int EgammaCutBasedEleId::TestWP(WorkingPoint workingPoint, const bool i
unsigned int idx = isEB ? 0 : 1;

// effective area for isolation
float AEff = ElectronEffectiveArea::GetElectronEffectiveArea(ElectronEffectiveArea::kEleGammaAndNeutralHadronIso03, eta, ElectronEffectiveArea::kEleEAData2011);
float AEff = ElectronEffectiveArea::GetElectronEffectiveArea(ElectronEffectiveArea::kEleGammaAndNeutralHadronIso03, eta, ElectronEffectiveArea::kEleEAData2012);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David asks, if this could not be made configurable instead of changing hard-coded identifiers?

@vadler
Copy link

vadler commented Feb 12, 2014

-1
The issue #2376 (comment) is currently dealt with in #2428 for 71X and the solution can easily be backported then. I switched this one to "rejected" to prevent too early integration...

@cmsbuild
Copy link
Contributor

Pull request #2376 was updated. @cmsbuild, @Degano, @nclopezo can you please check and sign again.

@vadler vadler mentioned this pull request Feb 19, 2014
Merged
@d4space
Copy link
Contributor Author

d4space commented Feb 23, 2014

#2428 is ported to CMSSW_5_3_X

@cmsbuild
Copy link
Contributor

Pull request #2376 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@monttj
Copy link
Contributor

monttj commented Feb 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@smuzaffar smuzaffar mentioned this pull request Feb 26, 2014
Closed
smuzaffar added a commit that referenced this pull request Feb 27, 2014
@smuzaffar
Merge pull request #2376 from d4space/Egamma
c2d11ce 
EleEAData2012
@smuzaffar smuzaffar merged commit c2d11ce into cms-sw:CMSSW_5_3_X Feb 27, 2014
@smuzaffar smuzaffar mentioned this pull request Feb 27, 2014
Closed
@d4space d4space deleted the Egamma branch April 3, 2014 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved fully-signed tests-pending
Projects
None yet
Milestone
CMSSW_5_3_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@d4space @cmsbuild @monttj @vadler @davidlange6 @smuzaffar