New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HCAL] Fix rechit flags for R45 filter #23777
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23777/5467 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @jaehyeok for master. It involves the following packages: RecoLocalCalo/HcalRecAlgos @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@jaehyeok I do not see any significant change reported in the DQM test. Is this due to the limited size of the samples? |
@fabiocos PR RelVal stat. is too small and not enough specific to see the effect. |
@fabiocos I think so. The level of changes is in the order of 0.01% in SingleMuon and 1% in JetHT datasets. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The HCAL R45 filter algorithm uses two flags: "HBHETS4TS5Noise" and "HBHEOOTPU". Both are set by https://github.com/cms-sw/cmssw/blob/master/RecoLocalCalo/HcalRecAlgos/interface/HBHEPulseShapeFlag.h and it still assumes that SOI is 4.
This PR fixes this issue by getting the SOI from HBHEDataFrame::presamples().
Small changes (increase in rejection rate) are expected in both data and MC in the R45 filter decision.
Following is the rate changes for MET+X triggers measured in JetHT sample (13k events) before and after the fix:
passedFIX/passedBUG HLTPath
0.964613 HLT_CaloMET70_HBHECleaned_v4
0.959184 HLT_CaloMET80_HBHECleaned_v4
0.952408 HLT_CaloMET90_HBHECleaned_v4
0.944777 HLT_CaloMET100_HBHECleaned_v4
0.509202 HLT_CaloMET250_HBHECleaned_v4
0.367521 HLT_CaloMET300_HBHECleaned_v4
0.311828 HLT_CaloMET350_HBHECleaned_v4
0.708633 HLT_PFMET200_HBHECleaned_v9
0.589474 HLT_PFMET250_HBHECleaned_v9
0.513889 HLT_PFMET300_HBHECleaned_v9
0.703557 HLT_PFMET200_HBHE_BeamHaloCleaned_v9
0.763975 HLT_PFMETTypeOne200_HBHE_BeamHaloCleaned_v9
0.998347 HLT_DiJet110_35_Mjj650_PFMET110_v9
0.997959 HLT_DiJet110_35_Mjj650_PFMET120_v9
0.997436 HLT_DiJet110_35_Mjj650_PFMET130_v9
0.810345 HLT_Rsq0p35_v15
0.710526 HLT_Rsq0p40_v15
0.988839 HLT_RsqMR300_Rsq0p09_MR200_v15
0.982788 HLT_RsqMR320_Rsq0p09_MR200_v15
0.992908 HLT_RsqMR300_Rsq0p09_MR200_4jet_v15
0.989583 HLT_RsqMR320_Rsq0p09_MR200_4jet_v15