New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added overflow bin to all the plots (muon validation) #23782
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23782/5471 |
A new Pull Request was created by @cedricpri for master. It involves the following packages: Validation/RecoMuon @vazzolini, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 8ec219a You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
The relvals timed out after 2 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
Dear @cedricpri , could you please make the title more explicit ? We can't guess from this title if you are talking about Hcal, Tracker, Muons (CMSSW is shared among many subsystems...) @vazzolini, @kmaeshima, @schneiml, @dmitrijus, @jfernan2 : In general, could you please pay attention to the title when reviewing a PR ? Thank you |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Sorry about that, next time I will choose a better title. It only concerns the muon validation code. I have just updated the title. |
thanks @cedricpri ! appreciated |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Overflow bin added to all the validation plots.