Revert "Improvements and fixes for the BPH-trigger offline DQM code"

[fabiocos]

Reverts #23738

The PR causes a list of reproducible crashes in CMSSW_10_2_X_2018-07-12-2300 for several workflows, e.g. 136.851, 136.852, ...

#0 0x00000035236ac8dd in waitpid () from /lib64/libc.so.6
#1 0x000000352363e4e9 in do_system () from /lib64/libc.so.6
#2 0x000000352363e820 in system () from /lib64/libc.so.6
#3 0x00007f6d4f254be8 in TUnixSystem::StackTrace() () from /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-07-12-1100/external/slc6_amd64_gcc630/lib/libCore.so
#4 0x00007f6d4f2570ec in TUnixSystem::DispatchSignals(ESignals) () from /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_2_X_2018-07-12-1100/external/slc6_amd64_gcc630/lib/libCore.so
#5
#6 0x00007f6d00ea751d in BPHMonitor::Prescale(std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, edm::Event const&, edm::EventSetup const&, HLTPrescaleProvider*) () from /build/fabiocos/102X/crash/prova/CMSSW_10_2_X_2018-07-12-1100/lib/slc6_amd64_gcc630/pluginDQMOfflineTriggerPlugins.so
#7 0x00007f6d00eabd3d in BPHMonitor::analyze(edm::Event const&, edm::EventSetup const&) () from /build/fabiocos/102X/crash/prova/CMSSW_10_2_X_2018-07-12-1100/lib/slc6_amd64_gcc630/pluginDQMOfflineTriggerPlugins.so

The lines below might hint at the cause of the crash.
You may get help by asking at the ROOT forum http://root.cern.ch/forum.
Only if you are really convinced it is a bug in ROOT then please submit a
report at http://root.cern.ch/bugs. Please post the ENTIRE stack trace
from above as an attachment in addition to anything else
that might help us fixing this issue.

#6 0x00007f6d00ea751d in BPHMonitor::Prescale(std::__cxx11::basic_string<char, std::char_traits, std::allocator >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, edm::Event const&, edm::EventSetup const&, HLTPrescaleProvider*) () from /build/fabiocos/102X/crash/prova/CMSSW_10_2_X_2018-07-12-1100/lib/slc6_amd64_gcc630/pluginDQMOfflineTriggerPlugins.so
#7 0x00007f6d00eabd3d in BPHMonitor::analyze(edm::Event const&, edm::EventSetup const&) () from /build/fabiocos/102X/crash/prova/CMSSW_10_2_X_2018-07-12-1100/lib/slc6_amd64_gcc630/pluginDQMOfflineTriggerPlugins.so

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23788/5479

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test workflow 136.851,136.852,136.853,136.854,136.855,136.86

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29103/console Started: 2018/07/13 14:26

[cmsbuild]

+1
Tested at: 263a5f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23788/29103/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
651f179
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23788/29103/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23788/29103/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23788/29103/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23788/136.854_RunMuonEG2018A+RunMuonEG2018A+HLTDR2_2018+RECODR2_2018reHLT_skimMuonEG_Prompt+HARVEST2018
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23788/136.86_RunCharmonium2018A+RunCharmonium2018A+HLTDR2_2018+RECODR2_2018reHLT_skimCharmonium_Prompt+HARVEST2018

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 105 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2886290
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2886099
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1451.104 KiB( 30 files compared)
• DQMHistoSizes: changed ( 136.85,... ): 90.694 KiB HLT/BPH
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

+1

temporary revert of this PR so as to avoid crashes, waiting for a fix

[fabiocos]

merge

[andrius-k]

+1

Signing for the sake of completeness.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.