New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance unit test to check TypeWithDict::byName #2381
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_1_X. Enhance unit test to check TypeWithDict::byName It involves the following packages: DataFormats/Common @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
DataFormats -- Enhance unit test to check TypeWithDict::byName
The tests are being triggered in jenkins. |
-1 Tested at: 7eae2ef You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVEST+MINIAODMC50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVEST+MINIAODMC50.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log |
This pull request is an enhancement to the dictionary tools unit tests. This enhancement would have found the error found in 7_0_X that caused an exception to be thrown if an attempt is made to put a long long or unsigned long long EDProduct into an event. This test applies equally well to ROOT5 and ROOT6.