New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Phase II Tracker Material scenarios to remove duplicate 20% one #23814
Fix Phase II Tracker Material scenarios to remove duplicate 20% one #23814
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23814/5508 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mdhildreth for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: d81c8bb You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test2023Geometry had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@mdhildreth - you need to update dict2023Geometry.py:
Please, do not forget to update https://cmssdt.cern.ch/lxr/source/Configuration/Geometry/README.md |
-1 |
please test |
@ianna Fixed now. If everything passes, could you please sign? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23814/5680 |
The tests are being triggered in jenkins. |
Pull request #23814 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
@ianna p.s. The README file was correct; the dictionary was wrong. |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Fix duplicate 20% percent material to 50 % scenario. D27 was supposed to be 50%