Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup obsolete PhysList and add G4Exp, G4Log to Urban93 #2382

Merged
merged 1 commit into from Feb 10, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 10, 2014

Obsolete Physics Lists LHEP, LHEP_EMV, QGSP_BERT_EMLGG, QGSP_BERT_EMLGN, QGSP_BERT_EMLNoDel are removed.

UrbanMscModel93 was cleaned up: G4Exp and G4Log are used instead of std::log, std::exp, two short methods inlined.

Results should be unchanged only some CPU advantage. This PR should be merged only to 7_1_GEANT10

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_1_GEANT10_X.

cleanup obsolete PhysList and add G4Exp, G4Log to Urban93

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@civanch
Copy link
Contributor Author

civanch commented Feb 10, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_GEANT10_X IBs unless changes or unless it breaks tests.

davidlt added a commit that referenced this pull request Feb 10, 2014
cleanup obsolete PhysList and add G4Exp, G4Log to Urban93
@davidlt davidlt merged commit 917e010 into cms-sw:CMSSW_7_1_GEANT10_X Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants