Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[102X][L1T][DQMOffline] Normalizing L1 vs offline histograms to bin area (Jets & Energy Sums) #23845

Merged

Conversation

kreczko
Copy link
Contributor

@kreczko kreczko commented Jul 19, 2018

Backport of #23669

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2018

A new Pull Request was created by @kreczko (Luke Kreczko) for CMSSW_10_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29194/console Started: 2018/07/19 12:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23845/29194/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892290
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892099
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

+1

1 similar comment
@thomreis
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@thomreis
Copy link
Contributor

thomreis commented Aug 2, 2018

Hi @fabiocos
can this PR be merged please so that it can run at the T0 as soon as possible?

@thomreis
Copy link
Contributor

thomreis commented Aug 8, 2018

Hi @fabiocos
can this be merged please?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fcd16ef into cms-sw:CMSSW_10_2_X Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants