Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two by-lumisection plots to ECAL DQM, for CMSSW master #23920

Merged
merged 1 commit into from Jul 25, 2018

Conversation

tanmaymudholkar
Copy link
Contributor

@tanmaymudholkar tanmaymudholkar commented Jul 21, 2018

(1) Added new by-lumisection plots to monitor the behavior of TTF4 flags
(2) Fixed the TTF4 trend plots to display number of masked towers only from the current lumisection.

PR for backport to CMSSW 10_1_X: 23921
PR for backport to CMSSW 10_2_X: 23952
PR for DQM deployment: 652

… and filled the TTF4 trend plots with masking status from the current lumisection only.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for master.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29384/console Started: 2018/07/24 13:47

@cmsbuild
Copy link
Contributor

-1

Tested at: 97caa53

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23920/29384/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@tanmaymudholkar
Copy link
Contributor Author

Hi @andrius-k , I'm not quite sure what caused the crash, but it appears to be unrelated to ECAL DQM.

@boudoul
Copy link
Contributor

boudoul commented Jul 24, 2018

Hi @tanmaymudholkar , the reason is mentioned above : the relvals timed out after 2 hours .

The tests should be retriggered

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29432/console Started: 2018/07/25 09:41

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23920/29432/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2889585
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2889393
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3583.245 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 150.0,... ): 162.824 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 150.0,... ): 20.934 KiB EcalBarrel/EBTriggerTowerTask
  • DQMHistoSizes: changed ( 4.22,... ): 81.404 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 4.22,... ): 10.463 KiB EcalBarrel/EBTriggerTowerTask
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit efedacb into cms-sw:master Jul 25, 2018
@tanmaymudholkar tanmaymudholkar deleted the TTF4ByLS_master branch July 25, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants