Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HLT menu 3p2 with muon fix (103X) #23949

Merged
merged 7 commits into from Jul 25, 2018

Conversation

silviodonato
Copy link
Contributor

Update to HLT menu 3p2 with muon fix (https://its.cern.ch/jira/browse/CMSHLT-1942).
The version without muon fix is #23942

@silviodonato
Copy link
Contributor Author

hold

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29341/console Started: 2018/07/23 16:15

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29381/console Started: 2018/07/24 11:37

@cmsbuild
Copy link
Contributor

Pull request #23949 was updated. @smuzaffar, @cmsbuild, @silviodonato, @Martin-Grunewald, @Dr15Jones, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23949/29381/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2889087
  • DQMHistoTests: Total failures: 44
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2888845
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 125.656 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 10824.0,... ): 45.689 KiB HLT/EGM
  • DQMHistoSizes: changed ( 10824.0,... ): -5.246 KiB HLT/JME
  • DQMHistoSizes: changed ( 10824.0,... ): 1.452 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 136.85 ): 45.658 KiB HLT/EGM
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@Martin-Grunewald
Copy link
Contributor

@silviodonato
AFAIK this is now ready to go! Can you please unhold and sign?
Also the 10_1 and 10_2 backport PRs?
Thanks!

@silviodonato
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Jul 25, 2018
@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

@Dr15Jones
please sign for core.
Thanks!

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a81866b into cms-sw:master Jul 25, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLT_3p2_103X_muonFix branch November 17, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants