Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to L3 Muon OI SeedGenerator (TSGForOI) for high efficiency #23988

Merged
merged 6 commits into from Aug 7, 2018

Conversation

bmahakud
Copy link
Contributor

@bmahakud bmahakud commented Jul 24, 2018

  • The fixes added is supposed to enhance the L3 Outside-in reconstruction efficiency up to 3-4% depending on eta region

  • Currently OI starts from L2 muons with

    • Trajectory State on Surface (TSOS)TSOS at outer tracker surface from L2 after updated with IP information (State-1)
    • TSOS on the outer tracker surface from L2(State-2)
  • Fix-I

    • In the current configuration seeds are created starting from both states (State-1, State-2) for almost all muons
    • In the new setup seeds are created
      • Mostly from State-1 (one updated with IP)
      • Both states are used only if
        • L2 muon valid hits < 20 (for eta <2.1)
        • L2 muon valid hits <30 (for eta >2.1)
  • Fix-II

    • In the current configuration 'PropagatorWithMaterial' is used to propagate from muon station to outer tracker surface (outside tracker volume) for seeding
    • Now using 'SteppingHelixPropagator' outside the tracker volume for seeding
    • Now using 'PropagatorWithMaterialParabolicMf' inside the tracker volume instead of 'PropagatorWithMaterial' for seeding
  • Fix-III

    • Seeds set the initial conditions for track fitting after trajectory building
    • In current Seed in the trajectory is created in the seed generator.
    • Now the seed created based on the last measurement at the end of pattern recognition sets the initial condition for track fitting
  • Fix-IV

    • Scale factors are used to inflate the TSOSs errors so that the window of hit search gets widened
    • Scale factors are calculated dynamically for optimizing efficiency

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bmahakud for master.

It involves the following packages:

HLTrigger/Configuration
RecoMuon/TrackerSeedGenerator

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@echapon, @battibass, @makortel, @abbiendi, @jhgoh, @Martin-Grunewald, @bellan, @HuguesBrun, @folguera, @calderona, @trocino, @geoff-smith, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29401/console Started: 2018/07/24 16:40

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23988/29401/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2889291
  • DQMHistoTests: Total failures: 1250
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2887851
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@@ -187,12 +187,47 @@ def customiseForEcalTestPR22254thresholdC(process):



def customizeHLTForL3OIPR(process):
for seedproducer in producers_by_type(process, "TSGForOI"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the PR number so that we find the PR later when just having the code here to be moved into ConfDB.



# CMSSW version specific customizations
def customizeHLTforCMSSW(process, menuType="GRun"):

# add call to action function in proper order: newest last!
# process = customiseFor12718(process)

customizeHLTForL3OIPR(process)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR number...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Martin-Grunewald
Thanks for letting me know. I will put it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Pull request #23988 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

-1

Tested at: a6fb7cc

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23988/29617/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.85 step2

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log

10824.0 step2
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018.log

250202.181 step3
runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

  • AddOn:

I found errors in the following addon tests:

cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-01-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Aug 1 23:20:32 2018-date Wed Aug 1 23:16:55 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Wed Aug 1 23:20:32 2018-date Wed Aug 1 23:16:55 2018 s - exit: 18688
cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-01-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Aug 1 23:23:48 2018-date Wed Aug 1 23:16:58 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed Aug 1 23:23:48 2018-date Wed Aug 1 23:16:58 2018 s - exit: 18688
cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-01-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Aug 1 23:23:59 2018-date Wed Aug 1 23:17:44 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Wed Aug 1 23:23:59 2018-date Wed Aug 1 23:17:44 2018 s - exit: 18688
cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-01-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018v32.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Aug 1 23:29:37 2018-date Wed Aug 1 23:23:55 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018v32,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v32 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v32_DATA.root --fileout file:RelVal_Raw_2018v32_DATA_HLT_RECO.root : FAILED - time: date Wed Aug 1 23:29:37 2018-date Wed Aug 1 23:23:55 2018 s - exit: 18688
cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-01-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018v32.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Aug 1 23:30:35 2018-date Wed Aug 1 23:24:02 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018v32,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018v32 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v32_MC.root --fileout file:RelVal_Raw_2018v32_MC_HLT_RECO.root : FAILED - time: date Wed Aug 1 23:30:35 2018-date Wed Aug 1 23:24:02 2018 s - exit: 18688
cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-01-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Aug 1 23:30:09 2018-date Wed Aug 1 23:25:30 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Aug 1 23:30:09 2018-date Wed Aug 1 23:25:30 2018 s - exit: 18688

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@slava77
Copy link
Contributor

slava77 commented Aug 1, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29622/console Started: 2018/08/02 00:02

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23988/29622/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891565
  • DQMHistoTests: Total failures: 1249
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2890126
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 6, 2018

+1

for #23988 fdb2c84

  • code changes are roughly in line with the PR description and the follow up code review.
    • since changes here affect only HLT objects, the reco review is mostly generic code quality and style-related
  • jenkins tests pass and comparisons with the baseline show differences only in HLT plots related to or dependent on the muon L3 reco.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants