New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiling with python3 #23989
compiling with python3 #23989
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23989/5683 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/GuiBrowsers @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
def _producersConsumers(self): | ||
if(not self._mother and not self._daughter): | ||
return | ||
for name,theDict in six.iteritems({"producer":self._mother, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised this actually improved the use of six.iteritems
!
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Ah this was a by hand fix of a bug introduced previously (I noticed because python would not compile it)
On 24 Jul 2018, at 10:35, Chris Jones <notifications@github.com<mailto:notifications@github.com>> wrote:
@Dr15Jones commented on this pull request.
________________________________
In FWCore/Utilities/scripts/cfg-viewer.py<#23989 (comment)>:
- self._saveData(name.capitalize(),
- self._parents[self._prodConsP]["creator"],
- [thedataFile,self._calcFilenames("modules")[0]])
- with open(fulldataFile,'w') as moth:
- moth.write(JSONFormat(theDict))
- def _saveData(self,name,base,jsonfiles):
- jsonfiles = " ".join(["%s%s"%(self._helperDir,x)for x in jsonfiles])
- temp={}
- temp["data-base"] = base
- temp["data-files"] = jsonfiles
- self._data[name] = temp
+ # write out mothers and daughters (producers/consumers).
+ def _producersConsumers(self):
+ if(not self._mother and not self._daughter):
+ return
+ for name,theDict in six.iteritems({"producer":self._mother,
Surprised this actually improved the use of six.iteritems !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23989 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw2aovDSU9OKiC4vjd12FeGMLb5Tvks5uJzBTgaJpZM4Vc2J_>.
|
+1 |
Fix remaining python3 compilation errors in FWCore subsystem
most were
Compiling './GuiBrowsers/python/Vispa/Gui/ZoomableScrollArea.py'...
*** Sorry: TabError: inconsistent use of tabs and spaces in indentation (ZoomableScrollArea.py, line 67)
which I fixed by applying autopep8 -i --select E101,W690
(a minimal set of fixers)
[its probably a bad sign for the future that ~8 files in FWCore have these space/tab issues...]