Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling with python3 #23989

Merged
merged 1 commit into from Jul 25, 2018
Merged

compiling with python3 #23989

merged 1 commit into from Jul 25, 2018

Conversation

davidlange6
Copy link
Contributor

Fix remaining python3 compilation errors in FWCore subsystem

most were

Compiling './GuiBrowsers/python/Vispa/Gui/ZoomableScrollArea.py'...
*** Sorry: TabError: inconsistent use of tabs and spaces in indentation (ZoomableScrollArea.py, line 67)

which I fixed by applying autopep8 -i --select E101,W690
(a minimal set of fixers)

[its probably a bad sign for the future that ~8 files in FWCore have these space/tab issues...]

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29402/console Started: 2018/07/24 16:41

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FWCore/GuiBrowsers
FWCore/ParameterSet
FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @Martin-Grunewald, @ahinzmann, @gkasieczka, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

def _producersConsumers(self):
if(not self._mother and not self._daughter):
return
for name,theDict in six.iteritems({"producer":self._mother,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this actually improved the use of six.iteritems !

@Dr15Jones
Copy link
Contributor

+1
much better than the last

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23989/29402/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2889291
  • DQMHistoTests: Total failures: 31
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2889070
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@davidlange6
Copy link
Contributor Author

davidlange6 commented Jul 24, 2018 via email

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 570c9a5 into cms-sw:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants